fix(ChannelManager): Remove threads from cache upon deletion #10883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
didinele
approved these changes
May 5, 2025
|
What if the ClientUser was in one of those threads, then the threadDelete event for that thread won‘t emit correctly now anymore. |
|
|
Qjuh
reviewed
May 7, 2025
Qjuh
approved these changes
May 7, 2025
almeidx
approved these changes
May 7, 2025
vladfrangu
approved these changes
May 9, 2025
Jiralite
added a commit
that referenced
this pull request
May 9, 2025
* fix(ChannelManager): remove threads from cache upon deletion * refactor: loop over thread ids --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
If a channel with threads is deleted, the threads are still accessible in the channel manager and the guild channel manager. This clears them.
Resolves #10871.
Status and versioning classification: