feat: add cycles cost endpoints #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
force-pushed
the
lpahlavi/add-cycles-cost-endpoints
branch
from
1248a02 to
b4be97a
Compare
lpahlavi
force-pushed
the
lpahlavi/add-cycles-cost-endpoints
branch
from
b4be97a to
a101ab5
Compare
lpahlavi
force-pushed
the
lpahlavi/add-cycles-cost-endpoints
branch
4 times, most recently
from
d9e44f4 to
1deb585
Compare
lpahlavi
force-pushed
the
lpahlavi/add-cycles-cost-endpoints
branch
from
1deb585 to
d7a8a66
Compare
lpahlavi
commented
Oct 29, 2025
src/memory.rs
Outdated
| // requests and responses in logs. | ||
| *counter = counter.wrapping_add(1); | ||
| Id::from(current_request_id) | ||
| Id::from(ConstantSizeId::from(current_request_id)) |
Contributor
Author
There was a problem hiding this comment.
@gregorydemay I realized that this is necessary so that the CyclesCost endpoints give the correct cost back. The reason is, that currently the requests get initialized with a ConstantSizeId::ZERO ID here (which is called here), but in the actual update endpoints, the IDs get changed from a ConstantSizeId to an Id::Number here.
Note that I opened another PR (#514) with the relevant changes, but didn't want to rebase this one as it was already in review. I would aim to merge that one first, and then merge those changes here. I did include some changes here already just so that the CI is green.
…-cycles-cost-endpoints
…-cycles-cost-endpoints
lpahlavi
added a commit
that referenced
this pull request
Oct 31, 2025
This PR refactors the way requests are created in the EVM RPC canister to make the way for #509 where `CyclesCost` endpoints are added to estimate the cycles cost of requests. The refactoring introduces a new `MultiRpcResult` struct which represents the HTTP outcalls required to answer a request. `MultiRpcResult` currently only has a public `send_and_reduce` method, however #509 adds a `cycles_cost` method. This will allow re-using the request creation logic (e.g. computing the estimated response size) between the actual request endpoints (e.g. `eth_getLogs`) and the cycles cost endpoints (e.g. `eth_getLogsCyclesCost`).
gregorydemay
approved these changes
Nov 3, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @lpahlavi for this PR! some minor comments but otherwise LGTM!
Merged
lpahlavi
added a commit
that referenced
this pull request
Nov 3, 2025
## 🤖 New release * `evm_rpc_client`: 0.1.0 -> 0.2.0 (✓ API compatible changes) * `evm_rpc`: 2.6.0 -> 2.7.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `evm_rpc_client` <blockquote> ## [0.2.0] - 2025-11-03 ### Added - Add `.request_cost()` method to `RequestBuilder` to compute the cycles cost of a request via the new `CyclesCost` query endpoints ([#509](#509)) - Add the option to configure a retry strategy in the EVM RPC client to e.g., try a request with increasingly many cycles if it fails to to insufficient cycles ([#512](#512)) [0.2.0]: evm_rpc_client-v0.1.0...evm_rpc_client-v0.2.0 </blockquote> ## `evm_rpc` <blockquote> ## [2.7.0] - 2025-11-03 ### Added - For each `eth_*` endpoint, add a new corresponding `eth_*CyclesCost` query endpoint with the same Candid arguments, that allows computing the cycles cost of calling the corresponding `eth_*` update endpoint ([#508](#508), [#509](#509)) ### Changed - Use constant-size request IDs in JSON-RPC requests to allow for consistent request cycles costs ([#514](#514)) [2.7.0]: v2.6.0...v2.7.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the refactoring from #508, this PR adds query endpoints for all
eth_*endpoints on the EVM RPC canister that allow estimating the number of cycles required for a request. This improves on the existingrequestCostendpoint in 2 significant ways:eth_getLogsCyclesCost) have the same signature as their update counterparts (e.g.eth_getLogs) instead of requiring the user to construct the raw JSON payload themselves.As a result, the existing
requestCostendpoint is left for backwards compatibility but is now deprecated.In addition, the
EvmRpcClientnow has arequest_cost()method that allows computing the estimated cost of a request with the new query endpoints.