refactor: prepare to add RequestCost endpoints
#508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
commented
Oct 24, 2025
lpahlavi
commented
Oct 24, 2025
lpahlavi
commented
Oct 24, 2025
| pub type MultiCallResults<T> = MultiResults<RpcService, T, RpcError>; | ||
| pub type ReducedResult<T> = canhttp::multi::ReducedResult<RpcService, T, RpcError>; | ||
|
|
||
| fn process_result<T>( |
Contributor
Author
There was a problem hiding this comment.
This method was moved from candid_rpc/mod.rs (unchanged).
lpahlavi
commented
Oct 24, 2025
lpahlavi
force-pushed
the
lpahlavi/refactor-multi-rpc-requests
branch
from
afe5e68 to
a65dec5
Compare
lpahlavi
commented
Oct 24, 2025
src/candid_rpc/tests.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
These tests were moved to rpc_client/tests.rs (unchanged).
lpahlavi
force-pushed
the
lpahlavi/refactor-multi-rpc-requests
branch
from
a65dec5 to
eddd95a
Compare
lpahlavi
changed the title
RequestCost endpoints
lpahlavi
force-pushed
the
lpahlavi/refactor-multi-rpc-requests
branch
from
eddd95a to
24b69e2
Compare
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for this refactoring @lpahlavi ! Some minor questions about lifetimes
gregorydemay
approved these changes
Oct 31, 2025
lpahlavi
added a commit
that referenced
this pull request
Nov 3, 2025
Building on the refactoring from #508, this PR adds query endpoints for all `eth_*` endpoints on the EVM RPC canister that allow estimating the number of cycles required for a request. This improves on the existing `requestCost` endpoint in 2 significant ways: * The new query endpoints (e.g. `eth_getLogsCyclesCost`) have the same signature as their update counterparts (e.g. `eth_getLogs`) instead of requiring the user to construct the raw JSON payload themselves. * The new query endpoints can be used to compute the cycles cost of requests with multiple RPC providers (e.g. with the default providers). As a result, the existing `requestCost` endpoint is left for backwards compatibility but is now deprecated. In addition, the `EvmRpcClient` now has a `request_cost()` method that allows computing the estimated cost of a request with the new query endpoints.
Merged
lpahlavi
added a commit
that referenced
this pull request
Nov 3, 2025
## 🤖 New release * `evm_rpc_client`: 0.1.0 -> 0.2.0 (✓ API compatible changes) * `evm_rpc`: 2.6.0 -> 2.7.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `evm_rpc_client` <blockquote> ## [0.2.0] - 2025-11-03 ### Added - Add `.request_cost()` method to `RequestBuilder` to compute the cycles cost of a request via the new `CyclesCost` query endpoints ([#509](#509)) - Add the option to configure a retry strategy in the EVM RPC client to e.g., try a request with increasingly many cycles if it fails to to insufficient cycles ([#512](#512)) [0.2.0]: evm_rpc_client-v0.1.0...evm_rpc_client-v0.2.0 </blockquote> ## `evm_rpc` <blockquote> ## [2.7.0] - 2025-11-03 ### Added - For each `eth_*` endpoint, add a new corresponding `eth_*CyclesCost` query endpoint with the same Candid arguments, that allows computing the cycles cost of calling the corresponding `eth_*` update endpoint ([#508](#508), [#509](#509)) ### Changed - Use constant-size request IDs in JSON-RPC requests to allow for consistent request cycles costs ([#514](#514)) [2.7.0]: v2.6.0...v2.7.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way requests are created in the EVM RPC canister to make the way for #509 where
CyclesCostendpoints are added to estimate the cycles cost of requests.The refactoring introduces a new
MultiRpcResultstruct which represents the HTTP outcalls required to answer a request.MultiRpcResultcurrently only has a publicsend_and_reducemethod, however #509 adds acycles_costmethod. This will allow re-using the request creation logic (e.g. computing the estimated response size) between the actual request endpoints (e.g.eth_getLogs) and the cycles cost endpoints (e.g.eth_getLogsCyclesCost).