Skip to content

fix: user manager fix #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix: user manager fix #6854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions api/auth/user/UserRestHandler_ent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,16 @@ func (handler UserRestHandlerImpl) checkRBACForUserCreate(token string, requestS
isAuthorised = handler.enforcer.Enforce(token, casbin.ResourceUser, casbin.ActionCreate, filter.Team)
case filter.Entity == bean2.CLUSTER_ENTITIY:
isAuthorised = handler.userCommonService.CheckRbacForClusterEntity(filter.Cluster, filter.Namespace, filter.Group, filter.Kind, filter.Resource, token, handler.CheckManagerAuth)
case filter.Entity == bean2.CHART_GROUP_ENTITY && len(roleFilters) == 1: //if only chartGroup entity is present in request then access will be judged through super-admin access
isAuthorised = isActionUserSuperAdmin
case filter.Entity == bean2.CHART_GROUP_ENTITY && len(roleFilters) > 1: //if entities apart from chartGroup entity are present, not checking chartGroup access
case filter.Entity == bean2.CHART_GROUP_ENTITY && len(roleFilters) == 1:
// If only chart group in direct permissions, but user is assigning role groups too,
// defer the chart group authorization to the role group check
if len(roleGroups) > 0 {
isAuthorised = true // Will be validated in role group section
} else {
isAuthorised = isActionUserSuperAdmin
}
case filter.Entity == bean2.CHART_GROUP_ENTITY && len(roleFilters) > 1:
// If there are other entities in addition to chart group, ignore chart group check
isAuthorised = true
default:
isAuthorised = false
Expand Down
Loading