Skip to content

Conversation

@Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Oct 17, 2025

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2648

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

This pull request fixes a bug in the user authorization logic within the UserRestHandler, refining access conditions for chart group entities. The enhancements improve security and functionality in user management, particularly with multiple role filters.

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes user authorization logic for chart group entities in the user management system. The fix addresses a scenario where chart group authorization was not properly handled when role groups were also being assigned.

  • Updated the authorization logic for chart group entities to properly handle cases with role groups
  • Added conditional logic to defer chart group authorization to role group validation when both are present
  • Improved code comments to clarify the authorization flow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@sonarqubecloud
Copy link

@Shivam-nagar23 Shivam-nagar23 merged commit 6d5160b into main Oct 17, 2025
12 of 14 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the fix-user-manager branch October 17, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants