Skip to content

fix: duplication of tags on giving same key-value pair #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 25, 2023
Merged

fix: duplication of tags on giving same key-value pair #4139

merged 7 commits into from
Oct 25, 2023

Conversation

@Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Oct 20, 2023 •
edited
Loading

Description

Fixes #4140

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

vikramdevtron
vikramdevtron previously approved these changes Oct 20, 2023
View reviewed changes
@Shivam-nagar23 Shivam-nagar23 self-assigned this Oct 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Shivam-nagar23 Shivam-nagar23 merged commit e524505 into main Oct 25, 2023
@Shivam-nagar23 Shivam-nagar23 deleted the fix-tags-duplication branch October 25, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d

Assignees

@Shivam-nagar23 Shivam-nagar23

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Duplication of tags on giving same key-value Pair

3 participants

@Shivam-nagar23 @vikramdevtron