fix: duplication of tags on giving same key-value pair (#4139)

* fix-duplicate

* unique-key

* duplicate-fix

* create app fix

Author: Shivam-nagar23

pkg/app/AppCrudOperationService.go

@@ -206,7 +206,7 @@ func (impl AppCrudOperationServiceImpl) UpdateLabelsInApp(request *bean.CreateAp
 			appLabelMap[uniqueLabelExists] = appLabel
 		}
 	}
-
+	appLabelDeleteMap := make(map[string]bool, 0)
 	for _, label := range request.AppLabels {
 		uniqueLabelRequest := fmt.Sprintf("%s:%s:%t", label.Key, label.Value, label.Propagate)
 		if _, ok := appLabelMap[uniqueLabelRequest]; !ok {
@@ -227,10 +227,13 @@ func (impl AppCrudOperationServiceImpl) UpdateLabelsInApp(request *bean.CreateAp
 				return nil, err
 			}
 		} else {
-			// delete from map so that item remain live, all other item will be delete from this app
-			delete(appLabelMap, uniqueLabelRequest)
+			// storing this unique so that item remain live, all other item will be delete from this app
+			appLabelDeleteMap[uniqueLabelRequest] = true
 		}
 	}
+	for labelReq, _ := range appLabelDeleteMap {
+		delete(appLabelMap, labelReq)
+	}
 	for _, appLabel := range appLabelMap {
 		err = impl.appLabelRepository.Delete(appLabel, tx)
 		if err != nil {

pkg/pipeline/CiCdPipelineOrchestrator.go

@@ -1021,18 +1021,23 @@ func (impl CiCdPipelineOrchestratorImpl) CreateApp(createRequest *bean.CreateApp
 	}
 	// create labels and tags with app
 	if app.Active && len(createRequest.AppLabels) > 0 {
+		appLabelMap := make(map[string]bool)
 		for _, label := range createRequest.AppLabels {
-			request := &bean.AppLabelDto{
-				AppId:     app.Id,
-				Key:       label.Key,
-				Value:     label.Value,
-				Propagate: label.Propagate,
-				UserId:    createRequest.UserId,
-			}
-			_, err := impl.appLabelsService.Create(request, tx)
-			if err != nil {
-				impl.logger.Errorw("error on creating labels for app id ", "err", err, "appId", app.Id)
-				return nil, err
+			uniqueLabelExists := fmt.Sprintf("%s:%s:%t", label.Key, label.Value, label.Propagate)
+			if _, ok := appLabelMap[uniqueLabelExists]; !ok {
+				appLabelMap[uniqueLabelExists] = true
+				request := &bean.AppLabelDto{
+					AppId:     app.Id,
+					Key:       label.Key,
+					Value:     label.Value,
+					Propagate: label.Propagate,
+					UserId:    createRequest.UserId,
+				}
+				_, err := impl.appLabelsService.Create(request, tx)
+				if err != nil {
+					impl.logger.Errorw("error on creating labels for app id ", "err", err, "appId", app.Id)
+					return nil, err
+				}
 			}
 		}
 	}