Skip to content

fix: The manager(non-admin user) of the application is unable to select a list of apps when assigning permissions. #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: The manager(non-admin user) of the application is unable to select a list of apps when assigning permissions. #4053

merged 2 commits into from
Oct 10, 2023

Conversation

@Ashish-devtron
Copy link
Contributor

@Ashish-devtron Ashish-devtron commented Oct 10, 2023 •
edited
Loading

Description

The issue occurs when we have uppercase character in project or app Name and user doesn't have super admin access.
When we check the access of user we were not changing the name to lowercase.

Fixes #4042

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ashish-devtron Ashish-devtron marked this pull request as ready for review October 10, 2023 07:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashish-devtron Ashish-devtron merged commit 8a643d7 into main Oct 10, 2023
@Ashish-devtron Ashish-devtron deleted the fix-app-min-rbac branch October 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d

2 more reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@subhashish-devtron subhashish-devtron subhashish-devtron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: The manager(non-admin user) of the application is unable to select a list of apps when assigning permissions.

4 participants

@Ashish-devtron @kripanshdevtron @subhashish-devtron