fix: The manager(non-admin user) of the application is unable to select a list of apps when assigning permissions. (#4053)

* App RBAC name fix

Author: Ashish-devtron

api/restHandler/AppRestHandler.go

@@ -19,7 +19,6 @@ package restHandler
 
 import (
 	"encoding/json"
-	"fmt"
 	client "github.com/devtron-labs/devtron/api/helm-app"
 	"github.com/devtron-labs/devtron/api/restHandler/common"
 	"github.com/devtron-labs/devtron/pkg/app"
@@ -330,7 +329,7 @@ func (handler AppRestHandlerImpl) GetAppListByTeamIds(w http.ResponseWriter, r *
 				accessedApps = append(accessedApps, app)
 				continue
 			}
-			object := fmt.Sprintf("%s/%s", project.ProjectName, app.Name)
+			object := handler.enforcerUtil.GetAppRBACNameByAppAndProjectName(project.ProjectName, app.Name)
 			if ok := handler.enforcer.Enforce(token, casbin.ResourceApplications, casbin.ActionGet, object); ok {
 				accessedApps = append(accessedApps, app)
 			}

util/rbac/EnforcerUtil.go

@@ -63,6 +63,7 @@ type EnforcerUtil interface {
 	GetRbacObjectsByAppIds(appIds []int) map[int]string
 	GetAllActiveTeamNames() ([]string, error)
 	GetRbacObjectsByEnvIdsAndAppId(envIds []int, appId int) (map[int]string, map[string]string)
+	GetAppRBACNameByAppAndProjectName(projectName, appName string) string
 }
 
 type EnforcerUtilImpl struct {
@@ -604,3 +605,7 @@ func (impl EnforcerUtilImpl) GetAllActiveTeamNames() ([]string, error) {
 	}
 	return teamNames, nil
 }
+
+func (impl EnforcerUtilImpl) GetAppRBACNameByAppAndProjectName(projectName, appName string) string {
+	return fmt.Sprintf("%s/%s", strings.ToLower(projectName), strings.ToLower(appName))
+}