Skip to content

Conversation

@kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Nov 8, 2022

Description

  1. Added support for dynamic handling of charts (user uploaded and devtron owned) in terms of pipeline strategies and app metrics support.
  2. Added Deployment type chart for devtron apps.

Fixes #2494

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test cases
  • Local dev Environment
  • QA Tests

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@kartik-579 kartik-579 linked an issue Nov 8, 2022 that may be closed by this pull request
2 tasks
kartik-579 and others added 4 commits November 15, 2022 11:39
* Add-deployment-chart

Signed-off-by: Kunal Verma <[email protected]>

* Update contrib-chart/reference-chart_4-15-0/templates/keda-autoscaling.yaml

Signed-off-by: Kunal Verma <[email protected]>
@gitguardian
Copy link

gitguardian bot commented Nov 17, 2022

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret 37a6af1 contrib-chart/reference-chart_4-15-0/env-values.yaml View secret
2763127 Generic High Entropy Secret 37a6af1 contrib-chart/reference-chart_4-15-0/secrets-test-values.yaml View secret
5236769 Generic High Entropy Secret 92e3eba scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/test-values.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nishant-d nishant-d merged commit ee0ea29 into main Dec 14, 2022
@nishant-d nishant-d deleted the dynamic-templates branch December 14, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: dynamic handling of deployment template charts

6 participants