Feat: Adding a Deployment Helm-chart #2391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kunal Verma <[email protected]>
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 365dda5 | contrib-chart/reference-chart_4-15-0/env-values.yaml | View secret |
| - | Generic High Entropy Secret | 365dda5 | contrib-chart/reference-chart_4-15-0/secrets-test-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
cc @Abhinav-26 |
verma-kunal
commented
Sep 23, 2022
contrib-chart/reference-chart_4-15-0/templates/keda-autoscaling.yaml
Outdated
Show resolved
Hide resolved
verma-kunal
commented
Sep 23, 2022
| {{- end }} | ||
| selector: | ||
| app: {{ template ".Chart.Name .name" . }} | ||
| {{- if eq .Values.deploymentType "BLUE-GREEN" }} |
There was a problem hiding this comment.
{{- if eq .Values.deploymentType "BLUE-GREEN" }}
I believe this line needs to be deleted as I have deleted the deploymentType field fromtest_values.yaml
Would like to confirm first?!
verma-kunal
commented
Sep 23, 2022
Comment on lines
+1
to
+23
| deployment: | ||
| strategy: | ||
| blueGreen: | ||
| autoPromotionSeconds: 30 | ||
| scaleDownDelaySeconds: 30 | ||
| previewReplicaCount: 1 | ||
| autoPromotionEnabled: false | ||
| rolling: | ||
| maxSurge: "25%" | ||
| maxUnavailable: 1 | ||
| canary: | ||
| maxSurge: "25%" | ||
| maxUnavailable: 1 | ||
| steps: | ||
| - setWeight: 25 | ||
| - pause: | ||
| duration: 15 # 1 min | ||
| - setWeight: 50 | ||
| - pause: | ||
| duration: 15 # 1 min | ||
| - setWeight: 75 | ||
| - pause: | ||
| duration: 15 # 1 min |
There was a problem hiding this comment.
I believe this section also needs to be updated/changed as we are not using Rollout & by default the strategy type of Deployment resource is RollingUpdates. A bit unsure about this section though!
Would like any thoughts here.
kartik-579
changed the base branch from
deployment-chart-v0
to
dynamic-templates
nishant-d
pushed a commit
that referenced
this pull request
Dec 14, 2022
* wip * updated sql script * fixed sql * added spec * Feat: Adding a Deployment Helm-chart (#2391) * Add-deployment-chart Signed-off-by: Kunal Verma <[email protected]> * Update contrib-chart/reference-chart_4-15-0/templates/keda-autoscaling.yaml Signed-off-by: Kunal Verma <[email protected]> * renamed helm chart * updated sql script for support of deployment type helm chart * updated script no * updated chart no * added test cases * fix sql * fix * review changes * review changes - part 2 * updated down sql * fix * updated validation checks * updated sql * fixed required tag * synced deployment chart with rollout-v4.16.0, renamed version * updated log * deployment chart changes * fix for strategy type deployment * updated deployment.yaml for deployment chart * removed strategy check for pipeline trigger * wip * Removing strategy configs in case of Recreate * Update pipeline-values.yaml * updated sql script no. * updated deployment.yaml * removed deployment type chart as default Signed-off-by: Kunal Verma <[email protected]> Co-authored-by: Kunal Verma <[email protected]> Co-authored-by: Prakarsh <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kunal Verma [email protected]
Description
Adds a Deployment Helm-chart
Fixes #2389
Type of change
How Has This Been Tested?
I tested the chart locally with -
helm template --debug . -f test_values.yamlHere is the output file - output.txt
Checklist: