Skip to content

[enhancement] Added PVC for nats-server #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 29, 2022
Merged

[enhancement] Added PVC for nats-server #1939

merged 9 commits into from
Jun 29, 2022

Conversation

@dheeth
Copy link
Contributor

@dheeth dheeth commented Jun 28, 2022

Description

This PR adds a PVC to nats-server which will persist the streams for nats

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested multiple times on multiple clusters

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@dheeth dheeth changed the base branch from main to release-bot June 29, 2022 14:12
@prakarsh-dt prakarsh-dt merged commit f2de164 into devtron-labs:release-bot Jun 29, 2022
pghildiyal pushed a commit that referenced this pull request Jun 30, 2022
@prakarsh-dt @dheeth
RELEASE: PR for v0.4.20 (#1935)
9f367bc 
* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated latest image of dashboard in installer

* Updated latest image of dashboard in installer

* Updated latest image of git-sensor in installer

* Updated latest image of lens in installer

* Updated latest image of kubewatch in installer

* [enhancement] Added PVC for nats-server (#1939)

* Updated nats-volume

* Renamed nats-server-vol and fixed nats deletion once

* Fixed nats volume name

* Fixed devtron custom override cm

* Fixed devtron custom override cm

* Fixed devtron custom override cm

* Removed devtron custom override cm

* Fixed nats volume conditions

Co-authored-by: Pawan Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakarsh-dt prakarsh-dt prakarsh-dt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dheeth @prakarsh-dt