[enhancement] Added PVC for nats-server (#1939)

* Updated nats-volume

* Renamed nats-server-vol and fixed nats deletion once

* Fixed nats volume name

* Fixed devtron custom override cm

* Fixed devtron custom override cm

* Fixed devtron custom override cm

* Removed devtron custom override cm

* Fixed nats volume conditions

Author: dheeth

manifests/installation-script

@@ -12,6 +12,7 @@ postgresSecret = kubectl get secret -n devtroncd postgresql-postgresql;
 enableLegacyApi = jsonSelect(operatorConfigMap, "data.ENABLE_LEGACY_API");
 helmInstallation = jsonSelect(operatorConfigMap, "data.INSTALLATION_THROUGH_HELM");
 
+
 baseURLScheme = jsonSelect(operatorConfigMap, "data.BASE_URL_SCHEME");
 baseURL = jsonSelect(operatorConfigMap, "data.BASE_URL");
 dexConfig = jsonSelect(operatorConfigMap, "data.DEX_CONFIG");
@@ -450,11 +451,18 @@ log("executed migrator setup command");
 ## #nats
 ## natsOperator = kubectl apply -n devtroncd natsOperator -u natsOperatorOverride;
 ## log("executed nats operator setup");
+hasNatsServerPod = kubectl get pod -n devtroncd devtron-nats-0;
+hasNatsServerPVC = kubectl get -n devtroncd pvc data-devtron-nats-0;
+if hasNatsServerPod && !hasNatsServerPVC {
+  log("Nats Server PVC not found");
+  natsStsDelete = kubectl delete -n devtroncd sts devtron-nats;
+  ignore = shellScript sleep50;
+  natsServerWithPVC = kubectl apply -n devtroncd natsServer -u natsServerOverride;
+  log("Nats PVC created and statefulset re-created");
+}
+else {
 ignore = shellScript sleep50;
 natsServer = kubectl apply -n devtroncd natsServer -u natsServerOverride;
-hasNatsServerPod = kubectl get pod -n devtroncd devtron-nats-0;
-if hasNatsServerPod {
-  natsPodDelete = kubectl delete -n devtroncd po "devtron-nats-0";
 }
 log(hasNatsServerPod);
 log("executed nats server setup");

manifests/yamls/nats-server.yaml

@@ -210,6 +210,8 @@ spec:
             mountPath: /etc/nats-config
           - name: pid
             mountPath: /var/run/nats
+          - name: data
+            mountPath: /tmp/nats/jetstream
 
         # Liveness/Readiness probes against the monitoring.
         #
@@ -280,6 +282,7 @@ spec:
         - -routez
         - -subz
         - -varz
+        - -jsz=all
         - -prefix=nats
         - -use_internal_server_id
         - http://localhost:8222/
@@ -289,6 +292,13 @@ spec:
 
 
   volumeClaimTemplates:
+  - metadata:
+      name: data
+    spec:
+      accessModes: [ "ReadWriteOnce" ]
+      resources:
+        requests:
+          storage: 5Gi
 ---
 # Source: nats/templates/tests/test-request-reply.yaml
 apiVersion: v1
@@ -326,3 +336,26 @@ spec:
           [ $name = test ]
 
   restartPolicy: Never
+---
+apiVersion: monitoring.coreos.com/v1
+kind: ServiceMonitor
+metadata:
+  labels:
+    kind: Prometheus
+    app: devtron-nats
+    chart: nats-0.9.2
+    release: monitoring
+  name: devtron-nats-server
+spec:
+  endpoints:
+  - interval: 30s
+    path: /metrics
+    port: metrics 
+  jobLabel: nats-server
+  namespaceSelector:
+    matchNames:
+    - devtroncd
+  selector:
+    matchLabels:
+      app.kubernetes.io/instance: devtron-nats
+      app.kubernetes.io/name: nats