-
Notifications
You must be signed in to change notification settings - Fork 56
Guided onboarding #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Guided onboarding #475
Changes from 87 commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
fb446f6
ONBOARDING GUIDE: added ui foe landing [age
shivani170 438a6b8
merge main
shivani170 6484508
ONBOARDING: added position of cards
shivani170 0374d86
DEPLOY & MANAGE:wip ui added after landing
shivani170 34a7671
MERGE
shivani170 a3a59d5
ONBOARDING: absolute position of cards fixed
shivani170 f3b933d
NAVIGATION: added between guided and landing page
shivani170 37ba2ee
Merge main
shivani170 dd31ef8
common guided component added
shivani170 aadcb8b
navigation issues fixed
shivani170 c550656
added sample ui
shivani170 fb65779
MERGE
shivani170 3f97eee
MERGE
shivani170 6f42a02
GUIDE PAGE: added toast
shivani170 8a4a972
Merge branch 'main' into guided-onboarding
shivani170 35d1b28
added getting started card
shivani170 a620db9
Merge branch 'main' into guided-onboarding
shivani170 61601bd
GUIDED ONBOARDING: UI completion and navigation
shivani170 0548e74
GUIDE PAGE: api integration
shivani170 2d70daa
Merge branch 'main' into guided-onboarding
shivani170 91b0be7
Merge with main
shivani170 6ca881c
APP LIST: testing for no app result with negation
shivani170 a90761e
self review done
shivani170 7009f29
ONBOARDING GUIDE: renaming of classname
shivani170 3942b0f
Merge branch 'main' into guided-onboarding
shivani170 ad42606
Merge branch 'main' into guided-onboarding
shivani170 89a1b26
code refactoring
shivani170 27032cc
Merge branch 'guided-onboarding' of https://github.com/devtron-labs/d…
shivani170 84b9cc2
NAVIGATIONROUTE: app count check added for onboard
shivani170 8849051
CODE REFACTORING
shivani170 8530a48
GETTING STARTED: tippy gandling on login fixed
shivani170 5eeb0a4
APP LIST: formatting removed
shivani170 3f0c72c
second level code review fixes
shivani170 4693dcb
NAVIGATION ROUTE: action click on onboarding via local storage
shivani170 3d37097
ONBOARDING GUIDE: close button on onboarding added
shivani170 13a326b
ONBOARDING: close icon navigation fixed
shivani170 ec5f491
FIXES
shivani170 14af7f5
added helm count in guide page
shivani170 c50e4a3
FIXED for setting all apis on onboarding
shivani170 5b71e15
PAGE HEADER: moved started tippy to page header
shivani170 54cae61
CODE FEEDNACK: second level done
shivani170 d40c1f2
Merge branch 'main' into guided-onboarding
vivek-devtron 13aaf3d
code optimization
shivani170 ee2291a
Merge branch 'guided-onboarding' of https://github.com/devtron-labs/d…
shivani170 6f0c9fe
css fixes
shivani170 eea2289
deploye and manage card navigation fixed
shivani170 2fb904d
left nav flicker fixed
shivani170 b8f0119
css fixes
shivani170 c9df9db
GUIDED ONBOARDING: functinality issue fixed
shivani170 d38dd93
Tiles & text overlap isssue fix
sohel-rp 94c2830
DEPLOY MANAGE: skip position fixed
shivani170 036dd02
NAVIGATION ROUTE: login count handled for ea only
shivani170 87c142a
LOGIN: updating login count in login file
shivani170 517f557
check role added
shivani170 c3cf307
ONBOARDING: posthog events added
shivani170 6794f39
card hover added
shivani170 281acff
ONBOARDING: replaced backward icon
shivani170 7042f47
NAVIGATION ROUTE: UNCOMMNETED code
shivani170 6d47347
GETTINGSTARTED: posthog events added on tippy
shivani170 4b6aeca
NO FOUND : bug fixed
shivani170 4dc07ce
SET UP proxy
shivani170 948d791
EA mode added update call for sso users
shivani170 70517ed
set expired fixed
shivani170 bb9f57a
fixed bug around count of first time login user
shivani170 6303826
Merge branch 'main' into guided-onboarding
shivani170 200f259
CSS FIXES
shivani170 2907321
CSS fixsx
shivani170 b02cfbf
CSS FIX
shivani170 58d70ee
Revert "CSS FIX"
shivani170 e3e6ee0
type added
shivani170 48a3003
Merge branch 'main' into guided-onboarding
shivani170 7a80782
node sass issue fixed
shivani170 2cea14b
CSS FIXES
shivani170 af26ed4
FIXED NAVIGATION OF HELM APPS
shivani170 057ccd2
redirection bug fix for non superadmin
shivani170 d9b90e4
REDIRECTION FIX
shivani170 a801967
NAVIGATION: bug fix
shivani170 1a9926e
CREATE-APP: border radius fixed
shivani170 d477182
setup prxy reverted
shivani170 91dca07
Merge branch 'main' into guided-onboarding
shivani170 93adbec
Tippy removed
shivani170 a96d286
CODE DEEDBACKS: incorporated
shivani170 42a6b83
feedback
shivani170 aed80ea
PostHogEvent Update
shivani170 2b40ea1
calling function asynchronously
shivani170 2bed4e6
code feedback
shivani170 8fbd630
code feedback
shivani170 f2b19c5
CODE FEEDBACKS
shivani170 d02ab81
feedbacks done
shivani170 a84db91
EVENT POSTHOG: broken fixed
shivani170 056d85f
DEPLOY GUIDE: added promise all
shivani170 e44a935
response made optional
shivani170 0c1f5db
fix
shivani170 dddf339
messaging fixed
shivani170 a8f5330
set up proxy reverted to demo1
shivani170 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,8 +14,6 @@ import { | |
| import { ReactComponent as Search } from '../../../assets/icons/ic-search.svg' | ||
| import { ReactComponent as ChartIcon } from '../../../assets/icons/ic-charts.svg' | ||
| import { ReactComponent as AddIcon } from '../../../assets/icons/ic-add.svg' | ||
| import InstallDevtronFullImage from '../../../assets/img/[email protected]' | ||
| import EmptyState from '../../EmptyState/EmptyState' | ||
| import { getInitData, buildClusterVsNamespace, getNamespaces } from './AppListService' | ||
| import { ServerErrors } from '../../../modals/commonTypes' | ||
| import { AppListViewType } from '../config' | ||
|
|
@@ -24,7 +22,7 @@ import { ReactComponent as Clear } from '../../../assets/icons/ic-error.svg' | |
| import DevtronAppListContainer from '../list/DevtronAppListContainer' | ||
| import HelmAppList from './HelmAppList' | ||
| import * as queryString from 'query-string' | ||
| import { OrderBy, SortBy } from '../list/types' | ||
| import { AppListPropType, OrderBy, SortBy } from '../list/types' | ||
| import { AddNewApp } from '../create/CreateApp' | ||
| import { mainContext } from '../../common/navigation/NavigationRoutes' | ||
| import '../list/list.css' | ||
|
|
@@ -37,9 +35,8 @@ import { FILE_NAMES } from '../../common/ExportToCsv/constants' | |
| import { getAppList } from '../service' | ||
| import moment from 'moment' | ||
| import { getUserRole } from '../../userGroups/userGroup.service' | ||
| import Tippy from '@tippyjs/react' | ||
|
|
||
| export default function AppList() { | ||
| export default function AppList({isSuperAdmin, appListCount} : AppListPropType) { | ||
| const location = useLocation() | ||
| const history = useHistory() | ||
| const params = useParams<{ appType: string }>() | ||
|
|
@@ -50,7 +47,6 @@ export default function AppList() { | |
| const [lastDataSync, setLastDataSync] = useState(false) | ||
| const [fetchingNamespaces, setFetchingNamespaces] = useState(false) | ||
| const [fetchingNamespacesErrored, setFetchingNamespacesErrored] = useState(false) | ||
|
|
||
| const [parsedPayloadOnUrlChange, setParsedPayloadOnUrlChange] = useState({}) | ||
| const [currentTab, setCurrentTab] = useState(undefined) | ||
| const [showCreateNewAppSelectionModal, setShowCreateNewAppSelectionModal] = useState(false) | ||
|
|
@@ -79,7 +75,7 @@ export default function AppList() { | |
| // on page load | ||
| useEffect(() => { | ||
| let _currentTab = | ||
| params.appType == AppListConstants.AppType.DEVTRON_APPS | ||
| params.appType === AppListConstants.AppType.DEVTRON_APPS | ||
| ? AppListConstants.AppTabs.DEVTRON_APPS | ||
| : AppListConstants.AppTabs.HELM_APPS | ||
| setCurrentTab(_currentTab) | ||
|
|
@@ -104,7 +100,7 @@ export default function AppList() { | |
| setEnvironmentListRes(initData.environmentListRes) | ||
| setMasterFilters(initData.filters) | ||
| setDataStateType(AppListViewType.LIST) | ||
| if (serverMode == SERVER_MODE.EA_ONLY) { | ||
| if (serverMode === SERVER_MODE.EA_ONLY) { | ||
| applyClusterSelectionFilterOnPageLoadIfSingle(initData.filters.clusters, _currentTab) | ||
| } | ||
| }) | ||
|
|
@@ -1014,65 +1010,70 @@ export default function AppList() { | |
|
|
||
| return ( | ||
| <div> | ||
| {dataStateType == AppListViewType.LOADING && ( | ||
| {dataStateType === AppListViewType.LOADING && ( | ||
| <div className="loading-wrapper"> | ||
| <Progressing pageLoader /> | ||
| </div> | ||
| )} | ||
| {dataStateType == AppListViewType.ERROR && ( | ||
| {dataStateType === AppListViewType.ERROR && ( | ||
| <div className="loading-wrapper"> | ||
| <ErrorScreenManager code={errorResponseCode} /> | ||
| </div> | ||
| )} | ||
| {dataStateType == AppListViewType.LIST && ( | ||
| {dataStateType === AppListViewType.LIST && ( | ||
| <> | ||
| {renderPageHeader()} | ||
| {renderMasterFilters()} | ||
| {renderAppliedFilters()} | ||
| {renderAppTabs()} | ||
| {serverMode == SERVER_MODE.FULL && renderAppCreateRouter()} | ||
| {params.appType == AppListConstants.AppType.DEVTRON_APPS && serverMode == SERVER_MODE.FULL && ( | ||
| <DevtronAppListContainer | ||
| payloadParsedFromUrl={parsedPayloadOnUrlChange} | ||
| appCheckListRes={appCheckListRes} | ||
| clearAllFilters={removeAllFilters} | ||
| sortApplicationList={sortApplicationList} | ||
| updateLastDataSync={updateLastDataSync} | ||
| setAppCount={setAppCount} | ||
| /> | ||
| )} | ||
| {params.appType == AppListConstants.AppType.DEVTRON_APPS && serverMode == SERVER_MODE.EA_ONLY && ( | ||
| <div style={{ height: 'calc(100vh - 250px)' }}> | ||
| <EAEmptyState | ||
| title={'Create, build, deploy and debug custom apps'} | ||
| msg={ | ||
| 'Create custom application by connecting your code repository. Build and deploy images at the click of a button. Debug your applications using the interactive UI.' | ||
| } | ||
| stateType={EAEmptyStateType.DEVTRONAPPS} | ||
| knowMoreLink={DOCUMENTATION.HOME_PAGE} | ||
| /> | ||
| </div> | ||
| )} | ||
| {params.appType == AppListConstants.AppType.HELM_APPS && ( | ||
| {serverMode === SERVER_MODE.FULL && renderAppCreateRouter()} | ||
| <> | ||
| <HelmAppList | ||
| serverMode={serverMode} | ||
| payloadParsedFromUrl={parsedPayloadOnUrlChange} | ||
| sortApplicationList={sortApplicationList} | ||
| clearAllFilters={removeAllFilters} | ||
| fetchingExternalApps={fetchingExternalApps} | ||
| setFetchingExternalAppsState={setFetchingExternalAppsState} | ||
| updateLastDataSync={updateLastDataSync} | ||
| setShowPulsatingDotState={setShowPulsatingDotState} | ||
| masterFilters={masterFilters} | ||
| /> | ||
| {fetchingExternalApps && ( | ||
| <div className="mt-16"> | ||
| <Progressing size={32} /> | ||
| </div> | ||
| {params.appType === AppListConstants.AppType.DEVTRON_APPS && | ||
| serverMode === SERVER_MODE.FULL && ( | ||
| <DevtronAppListContainer | ||
| payloadParsedFromUrl={parsedPayloadOnUrlChange} | ||
| appCheckListRes={appCheckListRes} | ||
| clearAllFilters={removeAllFilters} | ||
| sortApplicationList={sortApplicationList} | ||
| updateLastDataSync={updateLastDataSync} | ||
| appListCount={appListCount} | ||
| isSuperAdmin={isSuperAdmin} | ||
| openDevtronAppCreateModel={openDevtronAppCreateModel} | ||
| setAppCount={setAppCount} | ||
| /> | ||
| )} | ||
| {params.appType === AppListConstants.AppType.DEVTRON_APPS && | ||
| serverMode === SERVER_MODE.EA_ONLY && ( | ||
| <div style={{ height: 'calc(100vh - 250px)' }}> | ||
| <EAEmptyState | ||
| title='Create, build, deploy and debug custom apps' | ||
| msg='Create custom application by connecting your code repository. Build and deploy images at the click of a button. Debug your applications using the interactive UI.' | ||
| stateType={EAEmptyStateType.DEVTRONAPPS} | ||
| knowMoreLink={DOCUMENTATION.HOME_PAGE} | ||
| /> | ||
| </div> | ||
| )} | ||
| {params.appType === AppListConstants.AppType.HELM_APPS && ( | ||
| <> | ||
| <HelmAppList | ||
| serverMode={serverMode} | ||
| payloadParsedFromUrl={parsedPayloadOnUrlChange} | ||
| sortApplicationList={sortApplicationList} | ||
| clearAllFilters={removeAllFilters} | ||
| fetchingExternalApps={fetchingExternalApps} | ||
| setFetchingExternalAppsState={setFetchingExternalAppsState} | ||
| updateLastDataSync={updateLastDataSync} | ||
| setShowPulsatingDotState={setShowPulsatingDotState} | ||
| masterFilters={masterFilters} | ||
| /> | ||
| {fetchingExternalApps && ( | ||
| <div className="mt-16"> | ||
| <Progressing size={32} /> | ||
| </div> | ||
| )} | ||
| </> | ||
| )} | ||
| </> | ||
| )} | ||
| </> | ||
| )} | ||
| </div> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -482,3 +482,7 @@ | |
| background-color: var(--R100); | ||
| border: solid 1px var(--R200); | ||
| } | ||
|
|
||
| .first-app-container { | ||
| margin-top: 60px; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use " instead of ' in HTML properties