Guided onboarding #475
Merged
Guided onboarding #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/services/service.ts
Outdated
| return get(Routes.DASHBOARD_LOGGEDIN); | ||
| } | ||
|
|
||
| export interface LoginCountType extends ResponseType { |
There was a problem hiding this comment.
Please move these to types
src/services/service.ts
Outdated
| } | ||
|
|
||
| export function updateLoginCount(payload): Promise<ResponseType> { | ||
| return post('attributes/user/update', payload) |
There was a problem hiding this comment.
Add routes in constants
| to={`${match.path}/${URLS.GUIDE}`} | ||
| className="no-decor fw-6 cursor cn-9" | ||
| activeClassName="active" | ||
| onClick={() => redirectToDeployGuide(`/${URLS.GUIDE}`)} |
There was a problem hiding this comment.
Please avoid inline functions
sohel-rp
reviewed
Sep 5, 2022
| href={DOCUMENTATION.PREVIEW_DEVTRON} | ||
| rel="noreferrer noopener" | ||
| target="_blank" | ||
| onClick={() => OnClickedHandler(POSTHOG_EVENT_ONBOARDING.PREVIEW)} |
sohel-rp
reviewed
Sep 5, 2022
src/services/service.ts
Outdated
| } | ||
|
|
||
| export function getUserRole(): Promise<UserRole> { | ||
| return get(Routes.USER_CHECK_ROLE); |
There was a problem hiding this comment.
The same service function is present in userGroup.service.ts. Please use it.
sohel-rp
reviewed
Sep 5, 2022
| .deploy-manage__body{ | ||
| height: calc(100vh - 300px); | ||
| .deploy-card:hover{ | ||
| box-shadow: 0 8px 12px 0 rgba(30, 35, 96, 0.1), 0 1px 4px 0 rgba(0, 0, 0, 0.1); |
sohel-rp
reviewed
Sep 5, 2022
| } | ||
|
|
||
| .deploy__title{ | ||
| position: absolute; |
There was a problem hiding this comment.
Suggestion: Try using pre-defined CSS classes wherever possible.
sohel-rp
reviewed
Sep 5, 2022
| } from './userGroup.service' | ||
| import { get } from '../../services/api' | ||
| import { getEnvironmentListMin, getProjectFilteredApps } from '../../services/service' | ||
| import { getEnvironmentListMin, getProjectFilteredApps, getUserRole } from '../../services/service' |
sohel-rp
reviewed
Sep 5, 2022
src/config/constants.ts
Outdated
| GLOBAL_CONFIG_GIT_ACCESS_LINK: `${DOCUMENTATION_HOME_PAGE}/v/v0.5/getting-started/global-configurations/gitops#4.-git-access-credential`, | ||
| DEVTRON_UPGRADE: `${DOCUMENTATION_HOME_PAGE}/v/v0.5/getting-started/upgrade` | ||
| DEVTRON_UPGRADE: `${DOCUMENTATION_HOME_PAGE}/v/v0.5/getting-started/upgrade`, | ||
| PREVIEW_DEVTRON: 'https://preview.devtron.ai/dashboard', |
sohel-rp
reviewed
Sep 5, 2022
src/css/base.scss
Outdated
| line-height: 20px; | ||
| } | ||
|
|
||
| .lh-22{ |
sohel-rp
reviewed
Sep 5, 2022
sohel-rp
reviewed
Sep 5, 2022
src/services/service.ts
Outdated
| } | ||
|
|
||
| export function updatePostHogEvent(payload): Promise<PostHog> { | ||
| return post(`${Routes.TELEMETRY_EVENT}`, payload) |
There was a problem hiding this comment.
Simply say - Routes.TELEMETRY_EVENT
sohel-rp
reviewed
Sep 5, 2022
src/services/service.ts
Outdated
| export function updateLoginCount(payload): Promise<LoginCountType> { | ||
| return post(`${Routes.ATTRIBUTES_USER}/${Routes.UPDATE}`, payload) | ||
| } | ||
| interface PostHog extends ResponseType { |
There was a problem hiding this comment.
rename to PostHogEventResponse
sohel-rp
reviewed
Sep 5, 2022
|
|
||
| export const handlePostHogEventUpdate = (e, eventName?: string): void => { | ||
| const payload = { | ||
| eventType: eventName || e.target.dataset.posthog, |
There was a problem hiding this comment.
can we have an optional check on e.target?
sohel-rp
reviewed
Sep 5, 2022
| } | ||
|
|
||
| useEffect(() => { | ||
| setExpiryDate(+localStorage.getItem('clickedOkay')) |
There was a problem hiding this comment.
As discussed, handle undefined scenario
vivek-devtron
approved these changes
Sep 5, 2022
sohel-rp
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New UI feature added for new users with super admin access with 0 apps.
Base Devtron: Helm apps list
With CI/CD: Devtron apps list
Fixes devtron-labs/devtron#2213 devtron-labs/devtron#2228 devtron-labs/devtron#1972
https://docs.google.com/document/d/16PbZ0s_x9h3tt5jUzVoeRFSagdnBUfH_7CX8QBbEx7Y/edit
https://www.figma.com/file/mg4GcV3QQHU2NNv1SWr2va/Onboarding?node-id=636%3A696
Motivation
Increase product adoption among open-source users.
Proposal
-b3f8-c2a46bb96d1a.png">Fixes devtron-labs/devtron#1972
Type of change
How Has This Been Tested?
Tested out manually