Skip to content

Feature/sort devicon json and add sort check #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 11, 2022
Merged

Feature/sort devicon json and add sort check #1405

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a43057
indent and sort devicon.json
Snailedlt Oct 2, 2022
8bad6a4
add check to see if devicon.json is sorted
Snailedlt Oct 2, 2022
8cc1a42
Update devicon.json
lunatic-fox Dec 7, 2022
e2d3d8b
Apply suggestions from code review
Snailedlt Dec 7, 2022
a3ec40a
Apply suggestions from code review
Snailedlt Dec 11, 2022
cf1d44b
Update `devicon.json` with eb35d73a014618970ee84759b56883bfc33182b0
lunatic-fox Dec 11, 2022
18625f8
Merge branch 'develop' into feature/sort_devicon_json_and_add_sort_check
lunatic-fox Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/scripts/check_icon_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,15 @@ def main():
try:
all_icons = filehandler.get_json_file_content(args.devicon_json_path)

devicon_err_msg = []
#First check if devicon.json is sorted
if sorted(all_icons, key=lambda d: d['name']) != all_icons:
devicon_err_msg.append("devicon.json is not sorted correctly. Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position as seen [here](https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60)")

# get only the icon object that has the name matching the pr title
filtered_icon = util.find_object_added_in_pr(all_icons, args.pr_title)
print("Checking devicon.json object: " + str(filtered_icon))
devicon_err_msg = check_devicon_object(filtered_icon)
devicon_err_msg.append(check_devicon_object(filtered_icon))

# check the file names
filename_err_msg = ""
Expand All @@ -40,8 +45,8 @@ def main():
svg_err_msg = check_svgs(svgs)

err_msg = []
if devicon_err_msg != "":
err_msg.append(devicon_err_msg)
if devicon_err_msg != []:
err_ms.extend(devicon_err_msg)

if filename_err_msg != "":
err_msg.append(filename_err_msg)
Expand Down
Loading