Feature/sort devicon json and add sort check #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snailedlt
requested review from
a team,
Panquesito7,
Thomas-Boi and
amacado
and removed request for
a team and
Panquesito7
Snailedlt
added
the
hacktoberfest-accepted
Collaborator
Author
|
The sorting of devicon.json in this PR needs to be redone because devicon.json has been updated since it was last sorted |
Sort `devicon.json` of commit `77ff589df1fcffde36d9f3239d658046663d5588` from `develop` branch.
Contributor
|
Code used to sort import json
path = 'devicon.json'
with open(path) as file:
file: list[dict] = json.load(file)
file.sort(key=lambda e: e['name'])
file = json.dumps(file, indent=4) + '\n'
with open(path, 'w') as output_file:
output_file.write(file) |
Collaborator
Author
|
@lunatic-fox did you check if the check-icon script deemed it as sorted? |
Snailedlt
commented
Dec 7, 2022
Contributor
Not yet, I'll do later some tests in a private repo. |
Snailedlt
commented
Dec 7, 2022
lunatic-fox
requested changes
Dec 11, 2022
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
It'll work properly after fixing the reference error.
Preview
Co-authored-by: Josélio Júnior <[email protected]>
lunatic-fox
approved these changes
Dec 11, 2022
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
devicon.jsonis up-to-date and sorted with its latest version: eb35d73- Conflicts are resolved.
Looking good! ✔
Thank you for this great feature! 🚀
1 task
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* indent and sort devicon.json * add check to see if devicon.json is sorted * Update devicon.json Sort `devicon.json` of commit `1252ce95619756b5c237c72c605288e5eadc118f` from `develop` branch. * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Josélio Júnior <[email protected]> * Update `devicon.json` with 5460505 Co-authored-by: unknown <[email protected]> Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
devicon.jsoncheck_icon_pr.pyto see if devicon.json is still sortedThis PR closes #1337, #1327
Notes
Please check both if the functionality looks sound, and if the error messages can be improved