feat: duplicated proposals check

.semgrep/rules/sol-rules.yaml

@@ -125,6 +125,7 @@ rules:
         - packages/contracts-bedrock/src/universal/WETH98.sol
         - packages/contracts-bedrock/src/L2/SuperchainETHBridge.sol
         - packages/contracts-bedrock/src/governance/GovernanceToken.sol
+        - packages/contracts-bedrock/src/governance/VotingModule.sol
 
   - id: sol-style-return-arg-fmt
     languages: [solidity]
@@ -139,6 +140,7 @@ rules:
         - packages/contracts-bedrock/test/safe-tools
         - packages/contracts-bedrock/scripts/libraries/Solarray.sol
         - packages/contracts-bedrock/scripts/interfaces/IGnosisSafe.sol
+        - packages/contracts-bedrock/src/governance/VotingModule.sol
 
   - id: sol-style-doc-comment
     languages: [solidity]
@@ -241,6 +243,7 @@ rules:
         - packages/contracts-bedrock/src/libraries/Blueprint.sol
         - packages/contracts-bedrock/src/dispute/lib/Errors.sol
         - packages/contracts-bedrock/src/dispute/SuperFaultDisputeGame.sol
+        - packages/contracts-bedrock/src/governance/VotingModule.sol
         - packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
         - packages/contracts-bedrock/src/cannon/libraries/CannonErrors.sol
         - packages/contracts-bedrock/src/L2/SuperchainETHBridge.sol
@@ -341,6 +344,9 @@ rules:
         - packages/contracts-bedrock/src/dispute/SuperFaultDisputeGame.sol
         - packages/contracts-bedrock/src/dispute/SuperPermissionedDisputeGame.sol
         - packages/contracts-bedrock/src/governance/MintManager.sol
+        - packages/contracts-bedrock/src/governance/ProposalValidator.sol
+        - packages/contracts-bedrock/src/governance/VotingModule.sol
+        - packages/contracts-bedrock/src/governance/ProposalValidator.sol
         - packages/contracts-bedrock/src/periphery/TransferOnion.sol
         - packages/contracts-bedrock/src/periphery/faucet/Faucet.sol
         - packages/contracts-bedrock/src/periphery/faucet/authmodules/AdminFaucetAuthModule.sol

packages/contracts-bedrock/interfaces/governance/IOptimismGovernor.sol

@@ -0,0 +1,20 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+import {VotingModule} from "src/governance/VotingModule.sol";
+interface IOptimismGovernor {
+    function propose(
+        address[] memory targets,
+        uint256[] memory values,
+        bytes[] memory calldatas,
+        string memory description,
+        uint8 proposalType
+    ) external returns (uint256 proposalId);
+
+    function proposeWithModule(
+        VotingModule module,
+        bytes memory proposalData,
+        string memory description,
+        uint8 proposalType
+    ) external returns (uint256 proposalId);
+}

packages/contracts-bedrock/interfaces/governance/IProposalValidator.sol

@@ -0,0 +1,129 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+import {IGovernanceToken} from "./IGovernanceToken.sol";
+import {IOptimismGovernor} from "./IOptimismGovernor.sol";
+
+/// @title IProposalValidator
+/// @notice Interface for the ProposalValidator contract.
+interface IProposalValidator {
+    error ProposalValidator_InsufficientApprovals();
+    error ProposalValidator_ProposalAlreadyApproved();
+    error ProposalValidator_ProposalAlreadyInVoting();
+    error ProposalValidator_InsufficientVotingPower();
+    error ProposalValidator_InvalidAttestation();
+    error ProposalValidator_UnexistentProposal();
+
+    struct ProposalData {
+        address proposer;
+        ProposalType proposalType;
+        uint8 proposalTypeConfigurator;
+        bool inVoting;
+        mapping(address => bool) delegateApprovals;
+        uint256 remainingApprovalsRequired;
+    }
+
+    struct ImmutableProposalTypeData {
+        address[] targets;
+        uint256[] values;
+        string[] signatures;
+    }
+
+    enum ProposalType {
+        ProtocolOrGovernorUpgrade,
+        MaintenanceUpgrade,
+        CouncilMemberElections,
+        GovernanceFund,
+        CouncilBudget
+    }
+
+    event ProposalSubmitted(
+        bytes32 indexed proposalHash,
+        address indexed proposer,
+        address[] targets,
+        uint256[] values,
+        bytes[] calldatas,
+        string description,
+        ProposalType proposalType,
+        uint8 proposalTypeConfigurator
+    );
+
+    event ProposalApproved(
+        bytes32 indexed proposalHash,
+        address indexed approver
+    );
+
+    event ProposalMovedToVote(
+        bytes32 indexed proposalHash,
+        address indexed executor
+    );
+
+    event OwnershipTransferred(address indexed previousOwner, address indexed newOwner);
+
+    event MinimumVotingPowerSet(uint256 newMinimumVotingPower);
+
+    event VotingCycleBlockSet(uint256 newVotingCycleBlock);
+
+    event DistributionThresholdSet(uint256 newDistributionThreshold);
+
+    event ProposalApprovalThresholdSet(ProposalType proposalType, uint256 newApprovalThreshold);
+
+    function submitProposal(
+        address[] memory _targets,
+        uint256[] memory _values,
+        bytes[] memory _calldatas,
+        string memory _description,
+        ProposalType _proposalType,
+        uint8 _proposalTypeConfigurator,
+        bytes32 _attestationUid
+    ) external returns (bytes32 proposalHash_);
+
+    function approveProposal(bytes32 _proposalHash) external;
+
+    function moveToVote(
+        address[] memory _targets,
+        uint256[] memory _values,
+        bytes[] memory _calldatas,
+        string memory _description
+    ) external returns (uint256 governorProposalId_);
+
+    function setMinimumVotingPower(uint256 _minimumVotingPower) external;
+
+    function setVotingCycleBlock(uint256 _votingCycleBlock) external;
+
+    function setDistributionThreshold(uint256 _distributionThreshold) external;
+
+    function setProposalRequiredApprovals(ProposalType _proposalType, uint256 _requiredApprovals) external;
+
+    function renounceOwnership() external;
+
+    function canSignOff(address _delegate) external view returns (bool canSignOff_);
+
+    function transferOwnership(address newOwner) external;
+
+    function minimumVotingPower() external view returns (uint256);
+
+    function votingCycleBlock() external view returns (uint256);
+
+    function distributionThreshold() external view returns (uint256);
+
+    function votingToken() external view returns (IGovernanceToken);
+
+    function governor() external view returns (IOptimismGovernor);
+
+    function owner() external view returns (address);
+
+    function ATTESTATION_SCHEMA_UID() external view returns (bytes32);
+
+    function __constructor__(
+        address _owner,
+        IOptimismGovernor _governor,
+        IGovernanceToken _votingToken,
+        bytes32 _attestationSchemaUid,
+        uint256 _minimumVotingPower,
+        uint256 _votingCycleBlock,
+        uint256 _distributionThreshold,
+        ProposalType[] memory _proposalTypes,
+        uint256[] memory _requiredApprovals
+    ) external;
+}