feat: duplicated proposals check #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 0xOneTony <[email protected]> Signed-off-by: Chiin <[email protected]>
…ted-proposals-check
Co-authored-by: 0xOneTony <[email protected]> Signed-off-by: Chiin <[email protected]>
…ted-proposals-check
0xOneTony
reviewed
May 6, 2025
Member
0xOneTony
left a comment
0xOneTony
left a comment
There was a problem hiding this comment.
looks good! 2 small comments
packages/contracts-bedrock/src/governance/ProposalValidator.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/governance/ProposalValidator.sol
Outdated
Show resolved
Hide resolved
…ted-proposals-check
0xChin
changed the base branch from
feat/add-delegate-proposal-validator
to
sc-feat/permissionless-proposals
0xOneTony
approved these changes
May 6, 2025
0xOneTony
added a commit
that referenced
this pull request
Jul 29, 2025
* feat: add initial interface and logic * refactor: remove installed governor submodule * chore: remove xERC20 * feat: add proposal routing full flow * feat: check voting power and required proposals * refactor: rename to ProposalValidator * feat: add EAS validation for certain Proposal Types * feat: add duplicated proposals validation * chore: fix attestation schema approved address naming Co-authored-by: 0xOneTony <[email protected]> Signed-off-by: Chiin <[email protected]> * chore: remove management functions * chore: run pre-pr * refacto: follow style guide for function parameters and return variables * docs: add natspec, remove unused errors * chore: remove management functions from interface * chore: make voting token immutable * perf: make governor immutable * feat: add validator management functions * chore: add comments for imports in ProposalValidator * test: add unit tests * chore: run pre-pr * fix: semgrep warnings * chore: rename MaintenanceUpgradeProposals --> MaintenanceUpgrade * chore(semgrep): add excluded governance files * chore: fix coding style * chore: add ImmutableProposalTypeData * chore: improve errors naming * docs: improve natspec Co-authored-by: 0xOneTony <[email protected]> Signed-off-by: Chiin <[email protected]> * docs: add technical explanation on attestation validation function * feat: add _proposalTypeData mapping * chore: keep private functions consistency * chore: improve required attestation naming * chore: run pre-pr * chore: more descriptive errors * chore: confusing error name in submitProposal --------- Signed-off-by: Chiin <[email protected]> Co-authored-by: 0xOneTony <[email protected]>
0xOneTony
added a commit
that referenced
this pull request
Jul 29, 2025
* feat: add initial interface and logic * refactor: remove installed governor submodule * chore: remove xERC20 * feat: add proposal routing full flow * feat: check voting power and required proposals * refactor: rename to ProposalValidator * feat: add EAS validation for certain Proposal Types * feat: add duplicated proposals validation * chore: fix attestation schema approved address naming Co-authored-by: 0xOneTony <[email protected]> Signed-off-by: Chiin <[email protected]> * chore: remove management functions * chore: run pre-pr * refacto: follow style guide for function parameters and return variables * docs: add natspec, remove unused errors * chore: remove management functions from interface * chore: make voting token immutable * perf: make governor immutable * feat: add validator management functions * chore: add comments for imports in ProposalValidator * test: add unit tests * chore: run pre-pr * fix: semgrep warnings * chore: rename MaintenanceUpgradeProposals --> MaintenanceUpgrade * chore(semgrep): add excluded governance files * chore: fix coding style * chore: add ImmutableProposalTypeData * chore: improve errors naming * docs: improve natspec Co-authored-by: 0xOneTony <[email protected]> Signed-off-by: Chiin <[email protected]> * docs: add technical explanation on attestation validation function * feat: add _proposalTypeData mapping * chore: keep private functions consistency * chore: improve required attestation naming * chore: run pre-pr * chore: more descriptive errors * chore: confusing error name in submitProposal --------- Signed-off-by: Chiin <[email protected]> Co-authored-by: 0xOneTony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-776