Add mypy checks #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Second option is more obvious for sure. However:
I would suggest either leave the first one or use second with some dependency caching. |
kudep
added a commit
that referenced
this pull request
Oct 21, 2022
* add ydb_connector * lint * ydb docker * add setup extra * feature/ydb_connector: fix merge * feature/ydb_connector: massive upd, wip * feature/ydb_connector: fix sql, mongo, redis * fix: adapt ydb contexts serialization for uuid (#5) * fix: change context id to str type * fix: change id type to utf8 * fix: change serialization method for uuid Co-authored-by: Denis Kuznetsov <[email protected]> * feature/ydb_connector: fix ydb * feature/ydb_connector: fix style * feature/ydb_connector: rm useless files & upd examples Co-authored-by: Denis Kuznetsov <[email protected]> Co-authored-by: Evgeniy Egorov <[email protected]>
Collaborator
|
Second option is faster then our current unit-tests (because of that we do not have to wait three linting tests) and it's more atomic style. So I prefer the second one. |
kudep
approved these changes
Oct 24, 2022
Collaborator
|
We will wait until the end of addon's mega-merges. |
pseusys
approved these changes
Nov 4, 2022
Collaborator
|
Do we need this PR, i think it can be closed |
Member
Author
|
I think it should be used to add mypy check. The name of the branch is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here viewing codestyle check results is not convenient.
This pull request solves that problem in two ways:
In my opinion, the second solution is better.