merge/db_connector: merge db_connector into main repository #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename jobs from build to test and lint - Add docker-compose job to test_coverage - Lower cov_fail_under from 100 to 90
- Replace services in test_coverage action with a step - Fix flake8 codestyle
Seems to be causing issues with running the job
GitHub actions doesn't seem to support it
kudep
force-pushed
the
merge/db_connector
branch
from
73d10d9 to
819279c
Compare
…o cast of Context in db connectors
pseusys
approved these changes
Oct 20, 2022
kudep
approved these changes
Oct 20, 2022
Member
Author
|
Why remove mypy check? |
ruthenian8
approved these changes
Oct 20, 2022
Collaborator
|
#2 (comment) |
Member
Author
|
So what's the point of removing it? |
Collaborator
to see, that all linting tests are passed, except mypy of course |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.