Skip to content

fix: make artifact uploads work #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weitzman merged 8 commits into from
Jul 4, 2025
Merged

fix: make artifact uploads work #67

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
39cdebe
Pass along TESTDIR value to GITHUB_ENV
weitzman Jul 3, 2025
f2a888d
Tweak test
weitzman Jul 3, 2025
28c7b5c
See if Nightwatch artifact works
weitzman Jul 3, 2025
78b7e56
Fixing artifact uploads
stasadev Jul 4, 2025
99bbc66
Check if artifacts from several tests are stored
stasadev Jul 4, 2025
e48307a
Check if artifacts are still uploaded for failed tests
stasadev Jul 4, 2025
2431091
Add always()
stasadev Jul 4, 2025
0ec9fc8
revert debug commits
stasadev Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ jobs:

steps:
- uses: ddev/github-action-add-on-test@v2
env:
# Ensure that browser_output, junit, Nightwatch report are available as artifacts.
SKIP_CLEANUP: "true"
with:
ddev_version: ${{ matrix.ddev_version }}
token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -47,20 +44,25 @@ jobs:
- name: Archive browser_output
uses: actions/upload-artifact@v4
with:
name: browser_output
name: browser_output-${{ matrix.ddev_version }}
path: |
web/sites/simpletest/browser_output
${{ env.TESTDIR }}/web/sites/simpletest/browser_output

- name: Archive junits
uses: actions/upload-artifact@v4
with:
name: junits
name: junits-${{ matrix.ddev_version }}
path: |
*.junit.xml
${{ env.TESTDIR }}/web/*.junit.xml

- name: Zip Nightwatch reports
run: |
cd ${{ env.TESTDIR }}/web/core/reports
zip -r nightwatch.zip nightwatch

- name: Nightwatch reports
uses: actions/upload-artifact@v4
with:
name: nightwatch
name: nightwatch-${{ matrix.ddev_version }}
path: |
web/core/reports/nightwatch
${{ env.TESTDIR }}/web/core/reports/nightwatch.zip
9 changes: 7 additions & 2 deletions tests/test.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ setup() {

export DIR="$(cd "$(dirname "${BATS_TEST_FILENAME}")/.." >/dev/null 2>&1 && pwd)"
export PROJNAME="test-$(basename "${GITHUB_REPO}")"
export SKIP_CLEANUP=1
mkdir -p ~/tmp
export TESTDIR=$(mktemp -d ~/tmp/${PROJNAME}.XXXXXX)
export DDEV_NONINTERACTIVE=true
Expand Down Expand Up @@ -90,7 +89,13 @@ health_checks() {
teardown() {
set -eu -o pipefail
ddev delete -Oy ${PROJNAME} >/dev/null 2>&1
[ ! -z "${SKIP_CLEANUP}" ] || ( [ "${TESTDIR}" != "" ] && rm -rf ${TESTDIR} )
# Persist TESTDIR if running inside GitHub Actions. Useful for uploading test result artifacts
# See example at https://github.com/ddev/github-action-add-on-test#preserving-artifacts
if [ -n "${GITHUB_ENV:-}" ]; then
echo "TESTDIR=${TESTDIR}" >> "${GITHUB_ENV}"
else
[ "${TESTDIR}" != "" ] && rm -rf "${TESTDIR}"
fi
}

@test "install from directory" {
Expand Down