fix: make artifact uploads work #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
changed the title
stasadev
approved these changes
Jul 4, 2025
This was referenced Jul 4, 2025
Member
|
It looks like the same set of artifacts is uploaded twice, because |
Member
|
Finally, it works as expected https://github.com/ddev/ddev-selenium-standalone-chrome/actions/runs/16072520349?pr=67 Artifacts are created on fail, and contain results from all tests. |
Collaborator
Author
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Artifacts are not generated.
How This PR Solves The Issue
Uses these techniques to make it work:
Manual Testing Instructions
See artifacts in https://github.com/ddev/ddev-selenium-standalone-chrome/actions/runs/16070175432