Skip to content

Consolidate pre-commit config#12140

Merged
emmyoop merged 2 commits intomainfrom
er/fix-pre-commit
Nov 5, 2025
Merged

Consolidate pre-commit config#12140
emmyoop merged 2 commits intomainfrom
er/fix-pre-commit

Conversation

@emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 4, 2025

Related to #12129

Problem

We were manually keeping the precommit config in sync when we didn't need to

Solution

Use a local hook so pre-commit uses the same deps we use locally instead of in a separate pre-commit env

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.92%. Comparing base (1bd81f5) to head (e3822ae).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12140   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         203      203           
  Lines       24846    24846           
=======================================
+ Hits        22839    22840    +1     
+ Misses       2007     2006    -1     
Flag Coverage Δ
integration 88.87% <ø> (+0.08%) ⬆️
unit 65.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.16% <ø> (ø)
Integration Tests 88.87% <ø> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Nov 4, 2025
@emmyoop emmyoop marked this pull request as ready for review November 4, 2025 20:03
@emmyoop emmyoop requested a review from a team as a code owner November 4, 2025 20:03
@emmyoop emmyoop merged commit 8e800ce into main Nov 5, 2025
69 of 71 checks passed
@emmyoop emmyoop deleted the er/fix-pre-commit branch November 5, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes Skip Changelog Skips GHA to check for changelog file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants