Skip to content

Move from setup.py to pyproject.toml#12129

Merged
emmyoop merged 13 commits intomainfrom
er/pyprojecttoml
Nov 6, 2025
Merged

Move from setup.py to pyproject.toml#12129
emmyoop merged 13 commits intomainfrom
er/pyprojecttoml

Conversation

@emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 29, 2025

Resolves #5696

Move to pyproject.toml. This leaves a shim of setup.py in place for now so as to not break other pipelines. At some point we should remove it.

Testing

###Next
Spike moving to hatch

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 29, 2025
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.95%. Comparing base (c170211) to head (d9d0064).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (38.88%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12129      +/-   ##
==========================================
+ Coverage   91.94%   91.95%   +0.01%     
==========================================
  Files         203      203              
  Lines       24846    24844       -2     
==========================================
+ Hits        22844    22846       +2     
+ Misses       2002     1998       -4     
Flag Coverage Δ
integration 88.83% <38.88%> (-0.07%) ⬇️
unit 65.19% <38.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.19% <38.88%> (+0.02%) ⬆️
Integration Tests 88.83% <38.88%> (-0.07%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emmyoop emmyoop force-pushed the er/pyprojecttoml branch 4 times, most recently from 2948e78 to d7733f6 Compare November 4, 2025 19:07
more simplification

revert linting

more simplification

fix

don’t need it
@emmyoop emmyoop marked this pull request as ready for review November 6, 2025 01:21
@emmyoop emmyoop requested a review from a team as a code owner November 6, 2025 01:21
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The future is here ❤️

@emmyoop emmyoop merged commit 7e10fc7 into main Nov 6, 2025
59 of 62 checks passed
@emmyoop emmyoop deleted the er/pyprojecttoml branch November 6, 2025 14:08
@b-per
Copy link
Contributor

b-per commented Nov 6, 2025

Spike moving to hatch

You misspelled uv 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CT-1067] [Spike] Impact/feasibility checks for pyproject.toml

3 participants