Unpin dependencies #209
Merged
Unpin dependencies #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsignell
approved these changes
Mar 22, 2022
Member
jsignell
left a comment
jsignell
left a comment
There was a problem hiding this comment.
LGTM. These don't match any pins on dask, so I think we can safely remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy and Pandas have been pinned in the docker images for a long time. Given that we pin the Dask version I would hope that conda can resolve this correctly and we shouldn't need further pinning. Given some issues raised by @charlesbluca I'm keen to unpin here.
cc @dask/maintenance for thoughts