-
Notifications
You must be signed in to change notification settings - Fork 72
Resolve independent cluster test failures #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
charlesbluca
merged 13 commits into
dask-contrib:main
from
charlesbluca:cluster-use-mamba
Mar 23, 2022
Merged
Resolve independent cluster test failures #437
charlesbluca
merged 13 commits into
dask-contrib:main
from
charlesbluca:cluster-use-mamba
Mar 23, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushdg
approved these changes
Mar 22, 2022
Collaborator
ayushdg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! This should be good in the short term for unblocking CI
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 89.02% 88.92% -0.10%
==========================================
Files 69 69
Lines 3326 3324 -2
Branches 653 647 -6
==========================================
- Hits 2961 2956 -5
Misses 296 296
- Partials 69 72 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breakage we've been seeing in independent cluster testing due to:
In particular, one big change we've made is that we now use a single session-wide client to perform all computations or random client operations - backed either by a local cluster or an independent cluster for our independent cluster testing. I've updated the handful of tests that manage client lifecycle stuff to avoid this causing larger failures, but it would be nice at some point to explore better scope options for the
clientfixture.cc @ayushdg