Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

In _apply_offset, we sometimes use dd.from_delayed() to construct the resulting dataframe, but do not explicitly pass a meta. This means that in some cases, we end up implicitly changing the meta of the input dataframe, which can cause issues later on if it doesn't match up with the computed dataframe (the cause of the test failures in #408).

This PR passes the input dataframe's meta to dd.from_delayed() so that it is preserved through the operation.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #420 (9fb1572) into main (0372ebc) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   89.02%   89.18%   +0.15%     
==========================================
  Files          69       69              
  Lines        3327     3328       +1     
  Branches      654      654              
==========================================
+ Hits         2962     2968       +6     
+ Misses        296      287       -9     
- Partials       69       73       +4     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/limit.py 92.85% <100.00%> (ø)
dask_sql/physical/utils/map.py 100.00% <100.00%> (ø)
dask_sql/_version.py 34.00% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0372ebc...9fb1572. Read the comment docs.

@charlesbluca charlesbluca merged commit 5beaf35 into dask-contrib:main Mar 8, 2022
@charlesbluca charlesbluca deleted the limit-apply-meta branch July 19, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants