Drop common column from result of cross join, remove from corresponding meta
#408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #300
In that PR, I assumed we could make the results of cross join operation consistent with the
metawe construct for it by simply adding thecommoncolumn we join on to themeta. I now understand that this doesn't work, as we don't necessarily know where thecommoncolumn will be in the result, and themetamust have the same column ordering as its dataframe.This PR resolves this by taking my original approach and just dropping the
commoncolumn from the resulting dataframe altogether.