-
Notifications
You must be signed in to change notification settings - Fork 72
Update pytest to generate a client fixture #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 95.48% 89.09% -6.39%
==========================================
Files 68 68
Lines 2987 3337 +350
Branches 554 653 +99
==========================================
+ Hits 2852 2973 +121
- Misses 83 289 +206
- Partials 52 75 +23
Continue to review full report at Codecov.
|
|
The dask cluster tests seem to be failing but I can't reproduce locally @charlesbluca any suggestions? |
|
Connected with @charlesbluca and thanks for the commit to fix the errors! Do you think it makes sense to merge this and open up an issue to discuss whether Dask-sql should indeed support running on a cluster which doesn't have dask-sql installed? |
|
@charlesbluca I've added a note around the fugue test that was disabled on an external cluster for the time being. Is this good to merge? |
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I think this should be good to merge in - thanks for the work here @ayushdg 🙂
Removes the
distributed.utils_testfixtures from conftest and creates a new fixture to generate the client.The primary motivation for this is that the client fixture from distributed also resets all non dask configurations that impacts changes in #392