-
Notifications
You must be signed in to change notification settings - Fork 72
[Review] Refactor ConfigContainer to use dask config #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 88.94% 89.17% +0.23%
==========================================
Files 68 69 +1
Lines 3337 3327 -10
Branches 657 654 -3
==========================================
- Hits 2968 2967 -1
+ Misses 297 287 -10
- Partials 72 73 +1
Continue to review full report at Codecov.
|
… rendering config yaml files
…o enh-dask-sql-config
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice 🙂 especially like the configuration reference page in the docs; just some questions related to the handling of Context.set_config and then I think this should be good to merge.
Also going to merge in the latest changes from #406 to see if that resolves the API reference issues in the docs build for this PR.
|
@charlesbluca Should be ready for another round of reviews. |
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for the work here @ayushdg 😄
This PR removes
ConfigContainerand utilities to modify them as added in #286 in favor of using upstream Dask's config module and the flexibility it provides.Key Changes:
sql.dask.groupby.aggregate.split_outrenamed tosql.groupby.split_outFunctionality Enabled:
dask.config.context.sql({"query_string"},config_options={options}).Checklist:
dask_sql.config