Skip to content

Use unique names for null/non-null groupby columns #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesbluca merged 1 commit into from
Nov 2, 2021
Merged

Use unique names for null/non-null groupby columns #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dask_sql/physical/utils/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ def get_groupby_with_nulls_cols(
is_null_column = ~(group_column.isnull())
non_nan_group_column = group_column.fillna(0)

# split_out doesn't work if both columns have the same name
is_null_column.name = f"{is_null_column.name}_{new_temporary_column(df)}"

group_columns_and_nulls += [is_null_column, non_nan_group_column]

if not group_columns_and_nulls:
Expand Down