Skip to content

Conversation

@charlesbluca
Copy link
Collaborator

This should unblock #286 by ensuring that all groupby columns computed by get_groupby_with_nulls_cols have unique names.

cc @ayushdg

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #289 (b755bb2) into main (e48d9c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          64       64           
  Lines        2797     2798    +1     
  Branches      421      421           
=======================================
+ Hits         2685     2686    +1     
  Misses         71       71           
  Partials       41       41           
Impacted Files Coverage Δ
dask_sql/physical/utils/groupby.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48d9c1...b755bb2. Read the comment docs.

Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesbluca for the fix. Can confirm that it unblocks my usecase and the changes lgtm!

@charlesbluca charlesbluca merged commit 77f1d87 into dask-contrib:main Nov 2, 2021
@charlesbluca charlesbluca deleted the groupby-split-out-fix branch January 19, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants