-
Notifications
You must be signed in to change notification settings - Fork 72
Add support for custom filters to attempt_predicate_pushdown
#1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ayushdg - This kind of functionality should make it a lot easier to manually "add on" filters that cannot be extracted from the graph. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 81.42% 81.59% +0.16%
==========================================
Files 78 78
Lines 4474 4509 +35
Branches 817 828 +11
==========================================
+ Hits 3643 3679 +36
+ Misses 650 644 -6
- Partials 181 186 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ayushdg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @rjzamora
|
Thanks for the review @ayushdg - Note that we may also want to include this update to normalize (though it is already in #1179, so the subtle "fix" can also remain separate) |
Follow-up to #1160
Makes it possible to combine (1) pre-existing, (2) extracted, and (3) manually-specified filters within
attempt_predicate_pushdown. Here, we assume that these three kinds of filters must always be combined as anandconjunction. However, any one of these three kinds of filters may correspond to a generalOr(And(...), ...)DNF expression.