Fix formatting in Objective-C interop documentation #6995
Conversation
Summary of ChangesHello @mit-mit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor formatting inconsistency within the Objective-C interop documentation. By removing an accidental '2.' from a numbered list, the change ensures that the document's structure is correct and that information is presented clearly and accurately to readers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a formatting error in the Objective-C interop documentation. The change correctly merges a list item that was previously split incorrectly, which enhances the clarity and readability of the text. The fix is accurate and well-executed. I have no further recommendations.
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Oops. Thanks for catching this!
|
Fix for the build failure is in #6996. |
|
Visit the preview URL for this PR (updated for commit 2496c2d): |
I tried out the revamped Objective-C interop instructions from #6942 (thank you for updating them 🙏 ) and noticed a handful of minor issues that this PR addresses: * Instruct people to add dependencies to the helpers `package:objective_c` and `package:ffi`. * Add a missing import to `package:objective_c` to the sample code to resolve `NSString`. * Adjusted some file paths to align with best practices (e.g. generate the bindings into the `lib` directory). * Fixed a nullability issue by checking `player == null` and bailing early. * ~Fixed an issue with the enumeration in the multithreading section.~ Already fixed in #6995. * Removed the `ignore_for_file` preamble configuration since FFIgen auto-generates `// ignore_for_file: type=lint`. I also changed the second half to use highlights in the sample code just like it is done in the first half. I find that easier for following along. Plus, in the end you get to see the complete code. I've also incorporated #6990 into this PR.
Fix unintentional linebreak in bullet list