Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Oct 15, 2025

Update The Objective-C interop documentation to use the new FFIgen config Dart API, instead of YAML configs. I haven't updated the Swift example, because that will soon be replaced by swiftgen.

Fixes dart-lang/native#2710

@liamappelbe liamappelbe requested a review from parlough October 15, 2025 00:38
@liamappelbe liamappelbe changed the title Interop doc fixes WIP: Interop doc fixes Oct 15, 2025
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Oct 15, 2025

Visit the preview URL for this PR (updated for commit af0282f):

https://dart-dev--pr6942-objc-update-w8nmy44j.web.app

@parlough
Copy link
Member

I believe the failure was from a version of Jaspr that had a regression. I updated the branch with main which should pull in the release with a fix.

I'm guessing swift isn't a supported language for the syntax highlighting? It works when I change the language to dart, but obviously that's not a viable solution. Any suggestions? Is there a list of supported languages somewhere?

You're right, Swift isn't supported yet, but if swift is specified, it should fall back to no syntax highlighting. The list of supported languages can be found in site/lib/src/extensions/code_block_processor.dart.

I'm planning to work on basic support for Swift soon, is the no highlighting fallback sufficient until I can finish that?

@liamappelbe
Copy link
Contributor Author

I'm planning to work on basic support for Swift soon, is the no highlighting fallback sufficient until I can finish that?

Yep, no hilighting is fine for now.

@liamappelbe liamappelbe changed the title WIP: Interop doc fixes Objective-C interop doc updates Oct 21, 2025
@liamappelbe
Copy link
Contributor Author

@parlough This is ready for review. PTAL

@liamappelbe liamappelbe marked this pull request as ready for review October 21, 2025 04:40
@parlough parlough requested a review from antfitch October 24, 2025 18:05
@parlough
Copy link
Member

parlough commented Oct 24, 2025

Sorry about the delay in reviewing this. I'll make sure to take a look before Monday!

\cc @antfitch For reviewing the writing and structure.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these updates look good to me after a few updates, thanks for coming back to them @liamappelbe!

Do wait for @antfitch's approval as well before landing :)

@antfitch antfitch requested review from parlough and removed request for antfitch October 27, 2025 19:24
@antfitch
Copy link
Collaborator

Overall these updates look good to me after a few updates, thanks for coming back to them @liamappelbe!

Do wait for @antfitch's approval as well before landing :)

No need for me this time. Triaging this back to you @parlough to land. Love the changes, folks!

@antfitch antfitch self-requested a review October 30, 2025 22:30
@antfitch
Copy link
Collaborator

antfitch commented Oct 30, 2025

Hey all, this is a bit larger than I first thought. @parlough, when you're finished with your review, let me know and I'll do a final edit pass.

Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the engineering pass with @parlough, I'll circle by with a writing pass.

liamappelbe and others added 18 commits November 4, 2025 10:21
@parlough parlough requested a review from antfitch November 3, 2025 23:40
liamappelbe and others added 2 commits November 4, 2025 11:09
Added my edits directly to the Objective-C interop documentation. Updated some wording and changed headings to active voice. Added heading anchors to preserve backwards compatibility with heading changes.
Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my edits directly to objective-c-interop.md. Nothing significant and everything looked great.

@parlough
Copy link
Member

parlough commented Nov 4, 2025

It seems Amanda's commit accidentally undid some of the changes you applied and made. Tomorrow I can reapply what's necessary and land this.

Thank you both!

@parlough parlough merged commit d16f353 into dart-lang:main Nov 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ffigen] Fix up documentation on dart.dev

4 participants