Skip to content

Boxpoints bug #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfahlgren merged 2 commits into from
Jan 29, 2026
Merged

Boxpoints bug #1871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f44968
reorder box points if opencv shuffled them around
joshqsumner Jan 29, 2026
9506b32
deepsource
joshqsumner Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions plantcv/plantcv/transform/detect_color_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,14 @@ def _macbeth_card_detection(rgb_img, **kwargs):
new_rect = cv2.minAreaRect(np.array(centers))
# Get the corners of the rectangle
box_points = cv2.boxPoints(new_rect).astype("float32")
# previously the boxpoints (corners of box) started from the top left and proceeded clockwise around the image.
# between opencv 4.12.0 and 4.13.0 there is an unexplained change to start boxPoints from
# the bottom right of the image, so now we have to find the bottom right point and make sure
# that it is in the bottom right
bottom_right_corner_index = np.argsort(-box_points.sum(axis=1))[0]
# if the largest sum (bottom right corner of box) is the first element then sort the elements properly.
if bottom_right_corner_index == 0:
box_points = box_points[[2, 3, 0, 1]]
# Calculate the perspective transform matrix from the minimum area rectangle
m_transform = cv2.getPerspectiveTransform(box_points, corners.astype("float32"))
# Transform the chip centers using the perspective transform matrix
Expand Down