Skip to content

Boxpoints bug#1871

Merged
nfahlgren merged 2 commits intov5.0from
boxpoints-bug
Jan 29, 2026
Merged

Boxpoints bug#1871
nfahlgren merged 2 commits intov5.0from
boxpoints-bug

Conversation

@joshqsumner
Copy link
Contributor

Describe your changes
Changes order of cv2.boxPoints output to what we are expecting in color card detection after a recent cv2 change seems to have changed the order of boxPoints output.

Type of update
This is a bug fix.

Associated issues
None

Additional context
Changing from v4.12.0 to v4.13.0 in opencv seems to have caused some test failures due to this problem.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Jan 29, 2026
@joshqsumner joshqsumner added the work in progress Mark work in progress label Jan 29, 2026
@deepsource-io
Copy link

deepsource-io bot commented Jan 29, 2026

Here's the code health analysis summary for commits 40cc9c8..9506b32. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@joshqsumner joshqsumner changed the base branch from main to v5.0 January 29, 2026 22:11
@joshqsumner joshqsumner requested a review from nfahlgren January 29, 2026 22:19
@nfahlgren nfahlgren added bugfix Bug fixes ready to review and removed work in progress Mark work in progress labels Jan 29, 2026
Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an epic debug!

@nfahlgren nfahlgren merged commit 243c09c into v5.0 Jan 29, 2026
5 checks passed
@nfahlgren nfahlgren deleted the boxpoints-bug branch January 29, 2026 23:39
@joshqsumner joshqsumner mentioned this pull request Feb 16, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants