rust: improve error retries #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksa Sarai <[email protected]>
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
added a commit
to cyphar/filepath-securejoin
that referenced
this pull request
Oct 20, 2025
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
added a commit
to cyphar/filepath-securejoin
that referenced
this pull request
Oct 20, 2025
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
added a commit
to cyphar/filepath-securejoin
that referenced
this pull request
Oct 20, 2025
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
added a commit
to cyphar/filepath-securejoin
that referenced
this pull request
Oct 20, 2025
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
added a commit
to cyphar/filepath-securejoin
that referenced
this pull request
Oct 31, 2025
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
added a commit
to cyphar/filepath-securejoin
that referenced
this pull request
Oct 31, 2025
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit 02d2e4b) Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
added a commit
to cyphar/filepath-securejoin
that referenced
this pull request
Oct 31, 2025
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit 02d2e4b) Signed-off-by: Aleksa Sarai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openat2resolver will now return-EAGAINif the number ofopenat2retries is exceeded -- this allows higher-level users easily detect if an
error is an indication they should retry (based on their own retry policy).
ErrorandErrorKindnow have acan_retryhelper that can be used tomake retry loops easier for callers.
Signed-off-by: Aleksa Sarai [email protected]