gopathrs: return raw errors from openat2 retry loop #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cyphar
force-pushed
the
openat2-retry
branch
2 times, most recently
from
37e13e2 to
17a6c54
Compare
Our ErrPossible* errors are conceptually equivalent to EXDEV so we should support checking against them the same way (this also lets users check this way too). Signed-off-by: Aleksa Sarai <[email protected]>
This is to match the new behavour from libpathrs, as it provides more reasonable information to downstream users (they can check for unix.EAGAIN and have their own custom retry logic). Ref: cyphar/libpathrs#265 Signed-off-by: Aleksa Sarai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to match the new behavour from libpathrs, as it provides more
reasonable information to downstream users (they can check for
unix.EAGAIN and have their own custom retry logic).
Ref: cyphar/libpathrs#265
Signed-off-by: Aleksa Sarai [email protected]