refactor: use the built-in max/min to simplify the code

[pkucode]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Use the built-in max/min from the standard library in Go 1.21 to simplify the code. https://pkg.go.dev/[email protected]#max

Summary by CodeRabbit

• Refactor
  • Streamlined internal logic for maintaining node structure, ensuring efficient processing while keeping overall functionality unchanged for users.

[coderabbitai]

Walkthrough

The changes update the implementation of the updateHeightSize method within the MemNode struct in the memiavl/mem_node.go file. The method now uses a more general max function to determine the maximum child node height, replacing the earlier specific maxUInt8 function which has been removed. The overall logic for updating the node's height and size remains unchanged.

Changes

File	Change Summary
memiavl/mem_node.go	Refactored updateHeightSize by replacing the specific maxUInt8 function with a general max function for comparing child node heights.

Sequence Diagram(s)

sequenceDiagram
    participant UHS as updateHeightSize
    participant LN as Left Child Node
    participant RN as Right Child Node
    participant M as max Function

    UHS->>LN: Retrieve left child height
    UHS->>RN: Retrieve right child height
    UHS->>M: Call max(left, right)
    M-->>UHS: Return maximum height
    UHS->>UHS: Update node height and size

Loading

Suggested reviewers

• yihuang

Poem

Hop, hop, I’m a bunny so light,
I see streamlined code taking flight.
Out with the old and in with the new,
Max functions dancing in a cleaner view.
CodeRabbit cheers with joy all day!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 142f969 and 97ff615.

📒 Files selected for processing (1)

• memiavl/mem_node.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• memiavl/mem_node.go

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: build (macos-14)
• GitHub Check: build (macos-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: unittest
• GitHub Check: integration_tests (gas)
• GitHub Check: integration_tests (slow)
• GitHub Check: integration_tests (upgrade)
• GitHub Check: integration_tests (gov)
• GitHub Check: integration_tests (ica)
• GitHub Check: integration_tests (ibc_update_client)
• GitHub Check: integration_tests (ibc_timeout)
• GitHub Check: integration_tests (ibc_rly_gas)
• GitHub Check: integration_tests (ibc_rly_evm)
• GitHub Check: integration_tests (ibc)
• GitHub Check: integration_tests (unmarked)
• GitHub Check: Run golangci-lint
• GitHub Check: Analyze (go)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkucode]

Thanks for your review!

[mmsqe]

@pkucode can you help to sign the commit?

[pkucode]

@pkucode can you help to sign the commit?

Of course. Signed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.54%. Comparing base (a3c2f70) to head (97ff615).
Report is 59 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1777       +/-   ##
===========================================
+ Coverage   16.87%   35.54%   +18.66%     
===========================================
  Files          72      127       +55     
  Lines        6163    11961     +5798     
===========================================
+ Hits         1040     4251     +3211     
- Misses       5000     7282     +2282     
- Partials      123      428      +305     

Files with missing lines	Coverage Δ
memiavl/mem_node.go	94.95% <100.00%> (ø)

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.