Skip to content

refactor: use the built-in max/min to simplify the code #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmsqe merged 3 commits into from
Apr 1, 2025
Merged

refactor: use the built-in max/min to simplify the code #1777

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d794a4
refactor: use the built-in max/min to simplify the code
pkucode Mar 28, 2025
142f969
Merge branch 'main' into main
mmsqe Apr 1, 2025
97ff615
lint
mmsqe Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions memiavl/mem_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
}

func (node *MemNode) updateHeightSize() {
node.height = maxUInt8(node.left.Height(), node.right.Height()) + 1
node.height = max(node.left.Height(), node.right.Height()) + 1
node.size = node.left.Size() + node.right.Size()
}

Expand Down Expand Up @@ -210,9 +210,3 @@
return err
}

func maxUInt8(a, b uint8) uint8 {
if a > b {
return a
}
return b
}
Loading