This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix linter errors#107
Merged
turkenh merged 3 commits intocrossplane-contrib:mainfrom Oct 14, 2021
turkenh:tiny-fix
Merged
Conversation
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Collaborator
Author
|
I had to increase the linter timeout 2mins to 10mins since it was taking too long. |
ulucinar
approved these changes
Oct 14, 2021
Collaborator
|
I think we will need to investigate/work on this linter issue. Why does it take too long / why when we retry it takes less time / does it store its progress between runs, etc. |
Collaborator
Author
Yeah definitely agree, opened this issue with some details to follow up on that. At this moment, I don't think it is urgent/critical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Tiny fix resolving linter error.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewable