Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 654245c

Browse files
authored
Merge pull request #107 from turkenh/tiny-fix
Fix linter errors
2 parents b7b1e9c + 9ed9825 commit 654245c

3 files changed

Lines changed: 15 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,22 @@ jobs:
6767
- name: Vendor Dependencies
6868
run: make vendor vendor.check
6969

70-
# This action uses its own setup-go, which always seems to use the latest
71-
# stable version of Go. We could run 'make lint' to ensure our desired Go
72-
# version, but we prefer this action because it leaves 'annotations' (i.e.
73-
# it comments on PRs to point out linter violations).
70+
# Go version coming with golangci-lint-action may not be our desired
71+
# go version. We deploy our desired go version and then skip go
72+
# installation in golangci-lint-action in the next step as suggested
73+
# in https://github.com/golangci/golangci-lint-action/issues/183
74+
- uses: actions/setup-go@v2
75+
with:
76+
go-version: ${{ env.GO_VERSION }}
77+
# We could run 'make lint' to ensure our desired Go version, but we
78+
# prefer this action because it leaves 'annotations' (i.e. it comments
79+
# on PRs to point out linter violations).
7480
- name: Lint
7581
uses: golangci/golangci-lint-action@v2
7682
with:
7783
version: ${{ env.GOLANGCI_VERSION }}
84+
skip-go-installation: true
85+
args: --timeout 10m0s
7886

7987
check-diff:
8088
runs-on: ubuntu-18.04

.golangci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
run:
2-
deadline: 2m
2+
deadline: 10m
33

44
skip-files:
55
- "zz_\\..+\\.go$"

config/rds/config.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@ limitations under the License.
1717
package rds
1818

1919
import (
20-
"github.com/crossplane-contrib/provider-tf-aws/config/common"
2120
"github.com/crossplane-contrib/terrajet/pkg/config"
21+
22+
"github.com/crossplane-contrib/provider-tf-aws/config/common"
2223
)
2324

2425
const (

0 commit comments

Comments
 (0)