Fix runtime exception thrown when parameter override not provided #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The templated declare_parameter method needs an override (or default value) since it returns the actual parameter value, otherwise we get an exception. To correctly declare a parameter without a default value, we should use a different signature. Related upstream issue: ros2/rclcpp#1691 Signed-off-by: Jacob Perron <[email protected]>
ayrton04
approved these changes
Jun 17, 2021
Collaborator
|
Thanks! |
emilnovak
pushed a commit
to EnjoyRobotics/robot_localization
that referenced
this pull request
Jul 26, 2021
…a-ros-pkg#675) The templated declare_parameter method needs an override (or default value) since it returns the actual parameter value, otherwise we get an exception. To correctly declare a parameter without a default value, we should use a different signature. Related upstream issue: ros2/rclcpp#1691 Signed-off-by: Jacob Perron <[email protected]>
cesar-lopez-mar
pushed a commit
to nobleo/robot_localization
that referenced
this pull request
Sep 14, 2021
…a-ros-pkg#675) The templated declare_parameter method needs an override (or default value) since it returns the actual parameter value, otherwise we get an exception. To correctly declare a parameter without a default value, we should use a different signature. Related upstream issue: ros2/rclcpp#1691 Signed-off-by: Jacob Perron <[email protected]>
SteveMacenski
pushed a commit
that referenced
this pull request
Sep 15, 2021
* Fix runtime exception thrown when parameter override not provided (#675) The templated declare_parameter method needs an override (or default value) since it returns the actual parameter value, otherwise we get an exception. To correctly declare a parameter without a default value, we should use a different signature. Related upstream issue: ros2/rclcpp#1691 Signed-off-by: Jacob Perron <[email protected]> * Fix different time sources error (#679) Signed-off-by: Christophe Bedard <[email protected]> Co-authored-by: Jacob Perron <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in #663
Fixes #674
The templated declare_parameter method needs an override (or default value) since
it returns the actual parameter value, otherwise we get an exception.
To correctly declare a parameter without a default value, we should use a different
signature.
Related upstream issue: ros2/rclcpp#1691