chore: remove references to AllowUpdateAfterExpiry, AllowUpdateAfterMisbehaviour#1843
chore: remove references to AllowUpdateAfterExpiry, AllowUpdateAfterMisbehaviour#1843charleenfei merged 18 commits intomainfrom
AllowUpdateAfterExpiry, AllowUpdateAfterMisbehaviour#1843Conversation
…c-go into charly/remove_ref_allow_update
charleenfei
requested review from
AdityaSripal,
chatton,
colin-axner,
crodriguezvega,
damiannolan and
seantking
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 80.07% 80.07% -0.01%
==========================================
Files 167 167
Lines 11750 11747 -3
==========================================
- Hits 9409 9406 -3
Misses 1925 1925
Partials 416 416
|
|
Sorry about the conflicts ❤️ Looks like most of those conflicts can be deleted -> "07-tendermint/types". Let me know if you need help going through them |
There was a problem hiding this comment.
LGTM! Thanks for fixing the conflicts!
Sorry I didn't mention this before, but it would be good to leave test cases ensuring we can update a frozen client (might want to just leave a test case updating an expired client as well. The value of the allow booleans of course don't matter in these cases
| if tc.FreezeClient { | ||
| subjectClientState.FrozenHeight = frozenHeight | ||
| } |
There was a problem hiding this comment.
We should probably leave the freeze client cases in since we unfreeze the client if it is frozen in the code
There was a problem hiding this comment.
ah, yea good point
5 participants
Description
closes: #1237
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes