Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Comments

EOL - onboarding (EXPOSUREAPP-14788)#5851

Merged
mtwalli merged 4 commits intofeature/14785-eolfrom
feature/14788-onboarding-eol
Feb 20, 2023
Merged

EOL - onboarding (EXPOSUREAPP-14788)#5851
mtwalli merged 4 commits intofeature/14785-eolfrom
feature/14788-onboarding-eol

Conversation

@SamuraiKek
Copy link
Contributor

@SamuraiKek SamuraiKek commented Feb 20, 2023

Subtask

Changes to the onboarding flow after EOL, skipping most of the screens.
For testing, changing the EOL date from the test manu won't work as the onboarding flow doesn't have access to the test menu. You'll have to change the hardcoded EOL date from the EolSettings class. go into the test menu, change the EOL date to sometime in the past and reset the app from the settings menu.

@SamuraiKek SamuraiKek requested a review from a team February 20, 2023 06:13
@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Feb 20, 2023
@SamuraiKek SamuraiKek added this to the 3.2.x milestone Feb 20, 2023
@mtwalli
Copy link
Contributor

mtwalli commented Feb 20, 2023

Subtask

Changes to the onboarding flow after EOL, skipping most of the screens. For testing, changing the EOL date from the test manu won't work as the onboarding flow doesn't have access to the test menu. You'll have to change the hardcoded EOL date from the EolSettings class.

I just tested it using my approach and I can see the right flow based on EolSettings from DEV menu. Please double check it ?

@SamuraiKek
Copy link
Contributor Author

Subtask
Changes to the onboarding flow after EOL, skipping most of the screens. For testing, changing the EOL date from the test manu won't work as the onboarding flow doesn't have access to the test menu. You'll have to change the hardcoded EOL date from the EolSettings class.

I just tested it using my approach and I can see the right flow based on EolSettings from DEV menu. Please double check it ?

Yes, it works.

@mtwalli mtwalli self-assigned this Feb 20, 2023
@mtwalli mtwalli changed the title Onboarding eol (EXPOSUREAPP-14788) EOL - onboarding (EXPOSUREAPP-14788) Feb 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

24.1% 24.1% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit ccc1e37 into feature/14785-eol Feb 20, 2023
@mtwalli mtwalli deleted the feature/14788-onboarding-eol branch February 20, 2023 12:46
mtwalli added a commit that referenced this pull request Feb 22, 2023
* Setup `Eol`

* Add Settings

* Dev Settings

* Home Screen proofing

* Stats

* Analytics

* Lint

* Cwa App stop inits

* Restart

* Notifications

* FAQ card

* Cancel worker

* Card in Home

* Tests

* Lint

* Fix stats

* fix tests

* Notification

* EOL - Recycle Bin (EXPOSUREAPP-14793) (#5846)

* EOL -  certificates (EXPOSUREAPP-14790) (#5849)

* add eol config

* add eol config

* Travel Validity Button toggle for certificate details

* EOL - Background Work (EXPOSUREAPP-14794) (#5852)

* Stop Dcc Wallet info

* App starter

* Update AppStarterTest.kt

* EOL - onboarding (EXPOSUREAPP-14788) (#5851)

* Skip onboarding screens for EOL.

* Fix test

* Check eol directly in vm.

* Eol bottom bar (EXPOSUREAPP-14791) (#5853)

* add eol bottom navigation menu

* hide / show  flags

* Update MainActivity.kt

---------

Co-authored-by: Mohamed <mohamed.metwalli@sap.com>

* EOL - Battery optimization / tracing  dialogs

* EOL - Disable deep-links (#5855)

* EOL - error logs (EXPOSUREAPP-14837) (#5857)

* Disable ENF / Logger

* lint

* EOL -  notifications (EXPOSUREAPP-14795) (#5854)

* Stop Dcc Wallet info

* App starter

* Update AppStarterTest.kt

* Person badges

* Remove unwanted trigger

* Block notifications

* Revert "Block notifications"

This reverts commit 30f91d6.

* Hide badges

* Badge in person

* Trigger only if not EOL

* Lint

* Hide options in menu and app information. (#5858)

* EOL - Shortcuts (EXPOSUREAPP-14804) (#5859)

* EOL- shortcuts

* Setup bottom nav early

* Lint

* Test

* Update AppEolTest.kt

---------

Co-authored-by: Nikolaus Schauersberger <nikolaus.schauersberger@gmail.com>
Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants