Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Comments

EOL - certificates (EXPOSUREAPP-14790)#5849

Merged
mtwalli merged 3 commits intofeature/14785-eolfrom
feature/14790_eol_certificates
Feb 20, 2023
Merged

EOL - certificates (EXPOSUREAPP-14790)#5849
mtwalli merged 3 commits intofeature/14785-eolfrom
feature/14790_eol_certificates

Conversation

@schauersbergern
Copy link
Contributor

@schauersbergern schauersbergern commented Feb 17, 2023

@schauersbergern schauersbergern added the maintainers Tag pull requests created by maintainers label Feb 17, 2023
@schauersbergern schauersbergern added this to the 3.2.x milestone Feb 17, 2023
@schauersbergern schauersbergern marked this pull request as ready for review February 17, 2023 11:19
@schauersbergern schauersbergern requested a review from a team February 17, 2023 11:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

26.3% 26.3% Coverage
0.0% 0.0% Duplication

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 17, 2023

A wish from my personal site: The PRs opened in the Android repo tend to only include a link to a JIRA ticket, which is not accessible by the community.
As we already discussed way back in corona-warn-app/cwa-documentation#402, this is not optimal for an Open-Source project.
So my wish: Please continue to provide descriptions for PRs, as there are still people reading here who don't have access to JIRA.

cc @dsarkar

@SamuraiKek SamuraiKek self-assigned this Feb 20, 2023
@mtwalli
Copy link
Contributor

mtwalli commented Feb 20, 2023 •
edited
Loading

A wish from my personal site: The PRs opened in the Android repo tend to only include a link to a JIRA ticket, which is not accessible by the community. As we already discussed way back in corona-warn-app/cwa-documentation#402, this is not optimal for an Open-Source project. So my wish: Please continue to provide descriptions for PRs, as there are still people reading here who don't have access to JIRA.

cc @dsarkar

@Ein-Tim

EOL stands for End of Life.
The App will simply disable some features at EOL and some feature will continue to work after EOL (Date). When you see EOL - feature name in a PR it means that this PR is applying a flag on this feature which will take effect at EOL

@mtwalli mtwalli changed the title Eol certificates (EXPOSUREAPP-14790) EOL - certificates (EXPOSUREAPP-14790) Feb 20, 2023
@mtwalli mtwalli merged commit 1d97c8b into feature/14785-eol Feb 20, 2023
@mtwalli mtwalli deleted the feature/14790_eol_certificates branch February 20, 2023 10:56
mtwalli added a commit that referenced this pull request Feb 22, 2023
@mtwalli @schauersbergern @SamuraiKek
EOL (EXPOSUREAPP-14785) (#5845)
7c70a4d 
* Setup `Eol`

* Add Settings

* Dev Settings

* Home Screen proofing

* Stats

* Analytics

* Lint

* Cwa App stop inits

* Restart

* Notifications

* FAQ card

* Cancel worker

* Card in Home

* Tests

* Lint

* Fix stats

* fix tests

* Notification

* EOL - Recycle Bin (EXPOSUREAPP-14793) (#5846)

* EOL -  certificates (EXPOSUREAPP-14790) (#5849)

* add eol config

* add eol config

* Travel Validity Button toggle for certificate details

* EOL - Background Work (EXPOSUREAPP-14794) (#5852)

* Stop Dcc Wallet info

* App starter

* Update AppStarterTest.kt

* EOL - onboarding (EXPOSUREAPP-14788) (#5851)

* Skip onboarding screens for EOL.

* Fix test

* Check eol directly in vm.

* Eol bottom bar (EXPOSUREAPP-14791) (#5853)

* add eol bottom navigation menu

* hide / show  flags

* Update MainActivity.kt

---------

Co-authored-by: Mohamed <mohamed.metwalli@sap.com>

* EOL - Battery optimization / tracing  dialogs

* EOL - Disable deep-links (#5855)

* EOL - error logs (EXPOSUREAPP-14837) (#5857)

* Disable ENF / Logger

* lint

* EOL -  notifications (EXPOSUREAPP-14795) (#5854)

* Stop Dcc Wallet info

* App starter

* Update AppStarterTest.kt

* Person badges

* Remove unwanted trigger

* Block notifications

* Revert "Block notifications"

This reverts commit 30f91d6.

* Hide badges

* Badge in person

* Trigger only if not EOL

* Lint

* Hide options in menu and app information. (#5858)

* EOL - Shortcuts (EXPOSUREAPP-14804) (#5859)

* EOL- shortcuts

* Setup bottom nav early

* Lint

* Test

* Update AppEolTest.kt

---------

Co-authored-by: Nikolaus Schauersberger <nikolaus.schauersberger@gmail.com>
Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mtwalli mtwalli mtwalli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SamuraiKek SamuraiKek

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Milestone

3.2.x

Development

Successfully merging this pull request may close these issues.

4 participants

@schauersbergern @Ein-Tim @mtwalli @SamuraiKek