Skip to content

fix(WSIViewport): add event listener for annotation removal #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sedghi merged 9 commits into from
Nov 28, 2025
+59 −4
Merged

fix(WSIViewport): add event listener for annotation removal #2461

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9cdc7b1
feat(WSIViewport): add event listener for annotation removal
mbellehumeur Nov 14, 2025
8ea0eb2
refactor(WSIViewport): rename annotation removal event constant for c…
mbellehumeur Nov 15, 2025
b8c1486
feat(WSIViewport): check that the annotation belongs to the wsi image…
mbellehumeur Nov 15, 2025
b7b4fa5
refactor(WSIViewport): replace constant with ToolsEvents for annotati…
mbellehumeur Nov 17, 2025
8012d16
refactor(WSIViewport): update annotation removal event to use central…
mbellehumeur Nov 26, 2025
e08ab3d
Merge branch 'main' of https://github.com/mbellehumeur/cornerstone3D …
mbellehumeur Nov 26, 2025
85712cb
fix(WSIViewport): add period to error message for missing webClient i…
mbellehumeur Nov 27, 2025
be0ec9f
pulling main
mbellehumeur Nov 28, 2025
4ea314d
remove CORNERSTONE_TOOLS_ANNOTATION_REMOVED from events
mbellehumeur Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/core/src/RenderingEngine/WSIViewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ import triggerEvent from '../utilities/triggerEvent';
import { peerImport } from '../init';
import microscopyViewportCss from '../constants/microscopyViewportCss';
import type { DataSetOptions } from '../types/IViewport';
import eventTarget from '../eventTarget';

let WSIUtilFunctions = null;
const EVENT_POSTRENDER = 'postrender';
const TOOLS_ANNOTATION_REMOVED_EVENT = 'CORNERSTONE_TOOLS_ANNOTATION_REMOVED';
Comment thread
mbellehumeur marked this conversation as resolved.
Outdated
/**
* A viewport which shows a microscopy view using the dicom-microscopy-viewer
* library. This viewport accepts standard CS3D annotations, and responds
Expand Down Expand Up @@ -61,6 +63,22 @@ class WSIViewport extends Viewport {
};

private viewer;
private annotationRemovedListener: EventListener = (evt: Event) => {
const { detail } = evt as CustomEvent<{
Comment thread
mbellehumeur marked this conversation as resolved.
annotation?: {
metadata?: {
FrameOfReferenceUID?: string;
};
};
}>;

const annotationFOR =
detail?.annotation?.metadata?.FrameOfReferenceUID ?? null;

if (!annotationFOR || annotationFOR === this.frameOfReferenceUID) {
this.postrender();
}
};

/**
* The VOI Range is used to apply contrast/brightness adjustments to the image.
Expand Down Expand Up @@ -130,13 +148,21 @@ class WSIViewport extends Viewport {
EVENTS.ELEMENT_DISABLED,
this.elementDisabledHandler
);
eventTarget.addEventListener(
TOOLS_ANNOTATION_REMOVED_EVENT,
this.annotationRemovedListener
);
}

private removeEventListeners() {
this.canvas.removeEventListener(
EVENTS.ELEMENT_DISABLED,
this.elementDisabledHandler
);
eventTarget.removeEventListener(
TOOLS_ANNOTATION_REMOVED_EVENT,
this.annotationRemovedListener
);
}

private elementDisabledHandler() {
Expand Down
Loading