fix(WSIViewport): add event listener for annotation removal #2461
+59
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedghi
reviewed
Nov 14, 2025
sedghi
reviewed
Nov 14, 2025
… before calling postrender
igoroctaviano
suggested changes
Nov 17, 2025
Member
|
can you pull from main, ci is failing |
…ized EVENTS import
…into fix/wsiViewport-delete-measurement CI fail
sedghi
reviewed
Nov 27, 2025
packages/core/src/enums/Events.ts
Outdated
| /** | ||
| * Triggers when a tools annotation has been removed. | ||
| */ | ||
| ANNOTATION_REMOVED = 'CORNERSTONE_TOOLS_ANNOTATION_REMOVED', |
Member
There was a problem hiding this comment.
I'm hesitant to add this in core, since we already have annotation removed in tools. So how about not do it here, and just use CORNERSTONE_TOOLS_ANNOTATION_REMOVED inside the wsi viewport?
Contributor
Author
There was a problem hiding this comment.
Done - that it how it was originally.
Merge branch 'main' of https://github.com/cornerstonejs/cornerstone3D into fix/wsiViewport-delete-measurement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ticket: 18378695060
Measurement is deleted but the canvas is not refreshed.
DeleteMeasurementProblem.mp4
Changes & Results
Added listener for delete annotation that calls postRender.
Testing
Use patient SIIM, Ravi
DeleteAfter.mp4
Checklist
PR
semantic-release format and guidelines.
Code
etc.)